1964793 - [ews] cleanup: Encapsulate update folder callbacks in a safe Rust interface.

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, enhancement)

Description

[Eleanor Dicharry]

We have a number of unsafe calls in ews_xpcom::client, mostly to the callback functions we are accepting via the XPCOM interface. Each of these unsafe calls involves taking Rust-native types, converting them to XPCOM types, and then calling an unsafe XPCOM method with the converted types. I believe that the idiomatic safe Rust approach to an interface like this would be to create an opaque wrapper for the callback types that handles the conversion to-from unsafe XPCOM functions/types.

This issue covers handling this specifically for IEwsFolderCallbacks.

This was the result of a small refactor I did as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1956568 , and Heather suggested I submit it as its own bug/patch in case we don't want this right now.

Comment 1

[Eleanor Dicharry]

Attachment: Bug 1964793 - Add memory-safe interface to IEwsFolderCallbacks. r=babolivier,heather,#thunderbird-back-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/760e7c0f8aff
Add memory-safe interface to IEwsFolderCallbacks. r=heather,babolivier