1964824 - Support nesting of settings in config-based settings

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Mark Striemer [:mstriemer]]

We will need to nest some settings under the parent setting. Add support for a setting itself to have items within it, which will be treated like any other setting, but be nested under their parent and get disabled when the parent is not checked/pressed

Here's an example config for Home > Firefox Home Content > Recent activity

{
  id: "recent-activity",
  l10nId: "recent-activity-label",
  items: [
    { id: "recent-activity-rows", l10nId: "recent-activity-rows-label", control: "select" },
    { id: "recent-activity-visited", l10nId: "recent-activity-visited-label" },
    { id: "recent-activity-bookmarks", l10nId: "recent-activity-bookmarks-label" },
    { id: "recent-activity-downloads", l10nId: "recent-activity-downloads-label" },
  ],
}

Comment 1

[Ed Lee :Mardak]

here's a quick hack from the blocked bug 1961210 to recursively create settings-group when there's nested items:

       result = checkbox;
     }
+    if (item.items) {
+      const container = document.createXULElement("vbox");
+      const subgroup = document.createElement("setting-group");
+      subgroup.classList.add("indent");
+      subgroup.config = item;
+      subgroup.getSetting = this.getSetting;
+      container.append(result, subgroup);
+      result = container;
+    }
     if (item.subcategory) {
       result.dataset.subcategory = item.subcategory;

https://phabricator.services.mozilla.com/D247542 where it includes the parent checkbox in the subcategory, e.g., for about:preferences#general-link-preview

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1964824 - Part 1: Style parent disabled inputs as disabled r?#recomp-reviewers

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Bug 1964824 - Part 2: Remove XUL config-based settings r?#recomp-reviewers

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1964824 - Part 3: Nesting for config-based settings r?#recomp-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13b4bf2804b2
Part 1: Style parent disabled inputs as disabled r=reusable-components-reviewers,desktop-theme-reviewers,hjones
https://hg.mozilla.org/integration/autoland/rev/0b349eefcafb
Part 2: Remove XUL config-based settings r=reusable-components-reviewers,settings-reviewers,mconley,hjones
https://hg.mozilla.org/integration/autoland/rev/9c3efb0aa027
Part 3: Nesting for config-based settings r=reusable-components-reviewers,settings-reviewers,hjones,mconley

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/13b4bf2804b2
https://hg.mozilla.org/mozilla-central/rev/0b349eefcafb
https://hg.mozilla.org/mozilla-central/rev/9c3efb0aa027