1983902 - moz-toggle missing disabled styles when settings the disabled attribute

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Mark Striemer [:mstriemer]]

When disabling a moz-toggle with the toggle.disabled = true property the disabled styling is not shown. This still works as expected when setting the disabled attribute

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1983902 - Show the disabled state on moz-toggle when using disabled property r?#recomp-reviewers

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1964824

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/331404b16ebc
https://hg.mozilla.org/integration/autoland/rev/5410ed6bd6a8
Show the disabled state on moz-toggle when using disabled property r=reusable-components-reviewer-rotation,akulyk

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5410ed6bd6a8

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:mstriemer, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox143 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Mark Striemer [:mstriemer]]

I don't think any of our toggles that get disabled are currently hitting this bug, so no need to uplift