Closed Bug 1965035 Opened 11 months ago Closed 11 months ago

DohSettingsStore.kt imports WebRTC but it does not use it

Categories

(Firefox for Android :: Browser Engine, defect)

Product:
Firefox for Android
Component:
Browser Engine
Platform:
All
Android
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
140 Branch
Tracking Flags:
Tracking Status
firefox138 --- wontfix
firefox139 --- wontfix
firefox140 --- fixed

People

(Reporter: pierov, Assigned: pierov)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1965035 - Remove an unused WebRTC import from DohSettingsStore. r?sekim
48 bytes, text/x-phabricator-request
Details | Review

Steps to reproduce

  1. Disable WebRTC on the mozconfig (--disable-webrtc)
  2. Build

Expected behavior

The build succeeds.

Actual behavior

The build fails because org.webrtc.EglBase.Context is not found.

Device information

  • Firefox version:
  • Android device model:
  • Android OS version:

Any additional information?

If I understand correctly, that import is not needed.
Indeed this try build succeeded without it.

Set release status flags based on info from the regressing bug 1934262

status-firefox138: --- → affected
status-firefox139: --- → affected
status-firefox140: --- → affected
Pushed by mbucher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/800883aa22b4 Remove an unused WebRTC import from DohSettingsStore. r=sekim,android-reviewers,pollymce

https://hg.mozilla.org/mozilla-central/rev/800883aa22b4

Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox140: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: