1965143 - [x11] `Update available` popup cut off

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Alice0775 White]

Attachment: screenshot

Steps to reproduce:

1. Launch Nightly that is not up-to-date

Actual results:
Update available popup cut off.
See screenshot

Comment 1

[Alice0775 White]

Attachment: about:support

Comment 2

[Alice0775 White]

Regression window:
https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=e63c3cb08527628aa38c00463d24a56d01666392&tochange=29c957dc0c6f710ef5e2471560a1f49e7c655db9

Suspect: Bug 1945221

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1945221

:emilio, since you are the author of the regressor, bug 1945221, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

I don't think it can be that. Bug 1945221 only touched windows code. Is there any chance to narrow it down further?

Comment 5

[Alice0775 White]

Sorry, comment#2 is wrong.
The glitch happens 80% probability at startup browser.

The correct regression window is:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=ff5432cc7e7c0d223330a7c8f09a89d797793f83&tochange=9efb94e533503b0cd1309c16d01d488a69941059

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Thanks Alice! that makes more sense :)

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Ok, for my own reference, I can repro on Nightly with:

setTimeout(() => AppMenuNotifications.showNotification("update-available"), 1000); focus()

On the browser console or so. But somehow not on a debug build :/

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1965143 - Remove popup special early out in nsWindow::RecomputeBounds. r=stransky!

This compositor delegate wasn't getting its client area updated because of this
early return. Popups usually get that via:

https://searchfox.org/mozilla-central/rev/4c065f1df299065c305fb48b36cdae571a43d97c/widget/gtk/nsWindow.cpp#1068,1074

But this window doesn't, because:

if (GdkIsX11Display() && mNoAutoHide) {
type = GTK_WINDOW_TOPLEVEL;
}

Remove this special-case for popups. Instead, fall through the regular
code-path. I don't see any obvious issues but we can revert this if
needed (the following patch also fixes the issue).

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1965143 - Remove X11 special-case for noautohide popups that end up using toplevel windows. r=stransky

As noted in the comment for Wayland, most noautohide popups already work
this way, as the noautohide attribute is dynamic. I did a quick smoke test of
these popups and they still remain not autohiding as expected, and follow their
anchor and so on.

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1965143 - Consistently do sync move-resizes from Move() / Resize() / ResizeInt(). r=stransky

This is more predictable (we were only doing it in Resize() /
ResizeInt(), not in Move()).

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c601ff44c35
Remove popup special early out in nsWindow::RecomputeBounds. r=stransky

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ab9095166c1
Remove X11 special-case for noautohide popups that end up using toplevel windows. r=stransky

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/641736ec7f25
Consistently do sync move-resizes from Move() / Resize() / ResizeInt(). r=stransky

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5c601ff44c35
https://hg.mozilla.org/mozilla-central/rev/1ab9095166c1
https://hg.mozilla.org/mozilla-central/rev/641736ec7f25

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox139 to wontfix.

For more information, please visit BugBot documentation.

Comment 16

[Emilio Cobos Álvarez [:emilio]]

I think we should let this ride the trains, it's a non-trivial change.

Comment 17

[Bogdan Maris, Desktop Test Engineering]

Reproduced the menu cut using an old Nightly build from 2025-05-09 on Ubuntu 22.04 (x11), verified that using a recent Nightly 141.0a1 build after the fix and a 141.0b3 Beta build the panel is not cut anymore.