1965515 - [Downloads v2] Update the UI on the downloads screen to support in progress downloads

Status: VERIFIED FIXED

(Firefox for Android :: Downloads, task)

Comment 1

[Nicholas Poon [:Nick]]

Attachment: Bug 1965515 - Part 1: Create FileItem.Status sealed interface to be used in FileItem

Comment 2

[Nicholas Poon [:Nick]]

Attachment: Bug 1965515 - Part 3: Allow SelectableListItem to modify icon tint and description text color

Comment 3

[Nicholas Poon [:Nick]]

Attachment: Bug 1965515 - Part 4: Update downloads UI to support in progress downloads

Comment 4

[Nicholas Poon [:Nick]]

Attachment: Bug 1965515 - Part 7: Enable live downloads in Nightly

Comment 5

[Nicholas Poon [:Nick]]

Attachment: Bug 1965515 - Part 2: Refactor ListItemContent out of ListItem and create belowListItemContent slot API in ListItem and SelectableListItem

Comment 6

[Nicholas Poon [:Nick]]

Attachment: Bug 1965515 - Part 5: Fix live download not showing if it has previously been cancelled

The issue here is that these download items have the same name, so we need to filter away the cancelled items before filtering by filename

Comment 7

[Nicholas Poon [:Nick]]

Attachment: Bug 1965515 - Part 6: Update file item description for streaming download

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7b3b83e7c1ef
https://hg.mozilla.org/integration/autoland/rev/ec7f822a93be
Part 1: Create FileItem.Status sealed interface to be used in FileItem r=android-reviewers,tthibaud
https://github.com/mozilla-firefox/firefox/commit/df60e9c5cc79
https://hg.mozilla.org/integration/autoland/rev/f0d5f672858b
Part 2: Refactor ListItemContent out of ListItem and create belowListItemContent slot API in ListItem and SelectableListItem r=android-reviewers,tthibaud
https://github.com/mozilla-firefox/firefox/commit/076d79695797
https://hg.mozilla.org/integration/autoland/rev/32823ccb5345
Part 3: Allow SelectableListItem to modify icon tint and description text color r=android-reviewers,tthibaud
https://github.com/mozilla-firefox/firefox/commit/84391a0c8ef8
https://hg.mozilla.org/integration/autoland/rev/ba5e3812c822
Part 4: Update downloads UI to support in progress downloads r=android-reviewers,android-l10n-reviewers,delphine,tthibaud
https://github.com/mozilla-firefox/firefox/commit/4ddedb95d655
https://hg.mozilla.org/integration/autoland/rev/2e67dd3dec88
Part 5: Fix live download not showing if it has previously been cancelled r=android-reviewers,tthibaud
https://github.com/mozilla-firefox/firefox/commit/fd8add133132
https://hg.mozilla.org/integration/autoland/rev/a421f12c0ee5
Part 6: Update file item description for streaming download r=android-reviewers,tthibaud
https://github.com/mozilla-firefox/firefox/commit/9b48c2adf7bf
https://hg.mozilla.org/integration/autoland/rev/4cda8b8ed2c3
Part 7: Enable live downloads in Nightly r=android-reviewers,giorga

Comment 9

[Nicholas Poon [:Nick]]

Hi QA,
When this gets merged into main, can you please verify that the live downloads feature works according to the figma?

We are already aware of a few bugs (under Bug 1949803):

• Investigate live download not showing up on downloads screen
• Triggering a download with the same name as a failed download will not show on downloads screen
• Update downloads screen and system notification to properly display streaming download
• If download fails on browser fragment, it is not shown on downloads screen

If you find any other bugs, can you file them under Bug 1949803? Thanks

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ec7f822a93be
https://hg.mozilla.org/mozilla-central/rev/f0d5f672858b
https://hg.mozilla.org/mozilla-central/rev/32823ccb5345
https://hg.mozilla.org/mozilla-central/rev/ba5e3812c822
https://hg.mozilla.org/mozilla-central/rev/2e67dd3dec88
https://hg.mozilla.org/mozilla-central/rev/a421f12c0ee5
https://hg.mozilla.org/mozilla-central/rev/4cda8b8ed2c3

Comment 11

[Mira Lobontiu (Android QA)]

Verified as implemented on the latest Firefox for Android Nightly 141.0a1 from 6/12 with an Oppo Find N2 Flip (Android 15), Oppo Find X3 Lite (Android 11), and Samsung Galaxy Tab S9 (Android 15)

Comment 12

[Mira Lobontiu (Android QA)]

Attachment: 1965515.jpg