1970176 - [Downloads v2] Refactor DownloadEstimator

Status: RESOLVED FIXED

(Firefox for Android :: Downloads, task)

Description

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

At the moment, DownloadEstimator takes totalBytes as a dependency. (sf). This means that we initialize this once per download but this makes it tricky for live downloads in the downloads screen because it's hard to find a place to initialize / store this.

We should investigate removing this dependency and instead, making the estimatedRemainingTime method take totalBytes as a parameter. Then, we can fix where we initialize DownloadEstimator for live downloads. Currently, it's in DefaultFileItemDescriptionProvider (added in Bug 1965511).

After this, we should also investigate if we can remove this dependency from DownloadJobState in AbstractFetchDownloadService. (sf). This was a temporary hack and is advised against because data classes should hold data and download estimator is not data

Comment 1

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1970176 - [Downloads v2] Refactor DownloadEstimator

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/276d6a0cf003
https://hg.mozilla.org/integration/autoland/rev/0df467ccd473
[Downloads v2] Refactor DownloadEstimator r=android-reviewers,tthibaud

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/0df467ccd473