1965946 - Visual updates to large cards

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task)

Description

[Nathan Barrett [:nbarrett]]

Reduce padding around card

Enable excerpts to show on large cards only

Comment 1

[Reem Hamoui]

Attachment: Bug 1965946 - UI updates to large card. r=#home-newtab-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcd1fde833b0
UI updates to large card. r=home-newtab-reviewers,npypchenko

Comment 3

[Serban Stanca [:SerbanS]]

Attachment: WIP: Revert "Bug 1965946 - UI updates to large card. r#home-newtab-reviewers,npypchenko" for causing newtab failures.

This reverts commit 9e30fa7fb20ee762fe6e3e2fbd30fbaba5faf612.

Comment 4

[Serban Stanca [:SerbanS]]

Attachment: Revert "Bug 1965946 - UI updates to large card. r#home-newtab-reviewers,npypchenko" for causing newtab failures. r=aryx

This reverts commit 9e30fa7fb20ee762fe6e3e2fbd30fbaba5faf612.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95ddf24b61f6
Revert "Bug 1965946 - UI updates to large card. r#home-newtab-reviewers,npypchenko" for causing newtab failures.

Comment 6

[Scott [:thecount] Downe]

What was the cause of this revert?

Comment 7

[Cristina Horotan [:chorotan]]

Backed out for causing newtab failures

Backout link

Push with failures

Failure log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1d4d2f8bb30
UI updates to large card. r=home-newtab-reviewers,npypchenko

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e1d4d2f8bb30

Comment 10

[Maxx Crawford [:maxx]]

Attachment: Bug 1965946 - UI updates to large card. r=#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D250895

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: This would impact the timeline for the refined card UI experiment which delays the feature being released to users
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See test plan in original patch: https://phabricator.services.mozilla.com/D250895
• Risk associated with taking this patch: Low
• Explanation of risk level: This patch is CSS only and only is enabled/applied to items with the pref enabled.
• String changes made/needed: No
• Is Android affected?: no

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f681414a4137
https://hg.mozilla.org/releases/mozilla-beta/rev/17e96577a8b5

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue using the steps from here on both grid and sections layouts, and I can confirm the following:

• The description is no longer displayed on the story card.
• The thumb up/down buttons have the same color as the context menu one.
• The thumb up/down buttons and the context menu one have the same size.
• The thumb up/down buttons animation is not restarted after the button is clicked and the story is hovered again.
• Small cards show the thumb up/down buttons when hovered.
• The title and publisher from the small cards are aligned to the left.
• On small cards, the publisher icon does not move when hovered.
• The action buttons and the publisher icon are correctly aligned.
• The title and the publisher icon (where available) are displayed in the bottom part of the card.

Verified using the latest Firefox Nightly 141.0a1 (Build ID: 20250602211130) on Windows 10 x64, macOS 15.4.1, and Ubuntu 24.04 x64.

Comment 14

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue using the steps from here on both grid and sections layouts, and I can confirm the following:

• The description is no longer displayed on the story card.
• The thumb up/down buttons have the same color as the context menu one.
• The thumb up/down buttons and the context menu one have the same size.
• The thumb up/down buttons animation is not restarted after the button is clicked and the story is hovered again.
• Small cards show the thumb up/down buttons when hovered.
• The title and publisher from the small cards are aligned to the left.
• On small cards, the publisher icon does not move when hovered.
• The action buttons and the publisher icon are correctly aligned.
• The title and the publisher icon (where available) are displayed in the bottom part of the card.

Verified using the latest Firefox Beta 140.0b5 (Build ID: 20250603113649 - build downloaded from Treeherder) on Windows 10 x64, macOS 15.4.1, and Ubuntu 24.04 x64.