1966237 - Fix TypeScript issues raised in PlacesQuery.sys.mjs and PlacesUtils.sys.mjs

Status: RESOLVED FIXED

(Toolkit :: Places, task, P2)

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1966237 - Fix TypeScript issues raised in PlacesQuery.sys.mjs and PlacesUtils.sys.mjs - r?standard8!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93e2500b2ed3
Fix TypeScript issues raised in PlacesQuery.sys.mjs and PlacesUtils.sys.mjs - r=Standard8

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing mass failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/50d7573913fe8b5b3d8ed2e6d64b25502c1f3539

Push with failures

Failure log ->

Comment 4

[Mark Banner (:standard8)]

The correct link for the push with failures is this one.

Comment 5

[James Teow [:jteow]]

The Date object being passed to toPRTime fails instanceof Date checks. I think it might be because the Javascript realm/context between the call site and the function site is different.

I reverted back to using Moritz's solution, with an additional type check to help Typescript with narrowing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/851839cae848
Fix TypeScript issues raised in PlacesQuery.sys.mjs and PlacesUtils.sys.mjs - r=Standard8

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/851839cae848