Closed Bug 1966240 Opened 1 year ago Closed 6 months ago

Refactor PlacesQuery.sys.mjs to have different types of CachedHistory

Categories

(Toolkit :: Places, task, P3)

task

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox149 --- fixed

People

(Reporter: jteow, Assigned: jteow)

References

Details

(Whiteboard: [sng])

Attachments

(1 file)

CachedHistory is three separate types and Typescript will enforce checking that any access to a variable does proper type checking before attempting to use method associated with it. To make this easier, we should either use one data type or split them into separate ones.

Extracted cache logic from PlacesQuery into separate classes to have
clear separation of concerns and allow future specialization of
sorting strategies.

Attachment #9493652 - Attachment description: WIP: - Bug 1966240 - Refactor PlacesQuery cache logic into dedicated class - r?#places-reviewers → WIP: - Bug 1966240 - Refactor PlacesQuery cache management logic into CacheUtils helper - r?#places-reviewers
Assignee: nobody → jteow
Attachment #9493652 - Attachment description: WIP: - Bug 1966240 - Refactor PlacesQuery cache management logic into CacheUtils helper - r?#places-reviewers → Bug 1966240 - Refactor PlacesQuery cache management logic into CacheUtils helper - r?#places-reviewers
Status: NEW → ASSIGNED
Whiteboard: [sng]
Attachment #9493652 - Attachment description: Bug 1966240 - Refactor PlacesQuery cache management logic into CacheUtils helper - r?#places-reviewers → Bug 1966240 - Refactor PlacesQuery cache management logic into a separate class - r?#places-reviewers
Pushed by jteow@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f0f1d5f5e7d1 https://hg.mozilla.org/integration/autoland/rev/566436e0445b Refactor PlacesQuery cache management logic into a separate class - r=places-reviewers,Standard8
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
QA Whiteboard: [qa-triage-done-c150/b149]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: