196626 - don't replace "keyword %s" with url immediately if url is javascript:*

Status: RESOLVED DUPLICATE of bug 224408

(Firefox :: Address Bar, enhancement)

Description

[Jesse Ruderman]

%s-keywords are replaced immediately in Phoenix, which is nice for most keyword
bookmarks but bad for javascript: keyword bookmarks ("keyword bookmarklets"?)

One keyword bookmarklet I use a lot is
ja: javascript:try{alert(eval(unescape("%s")))}catch(er){alert(er)}

In Mozilla (02/24), typing "ja document.links[0]" puts up a dialog without
changing the URL, so it's easy for me to edit the address bar again to do "ja
document.links[0].innerHTML".

In Phoenix (02/01 and 03/04), the address is replaced with
javascript:try{alert(eval(unescape("document.links.length")))}catch(er){alert(er)}
before the dialog appears.  This makes it harder to do several ja's in a row.

Comment 1

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 2

[Karl Guertin]

The other special case for js bookmarklets is bug 184269. Not completely related
but someone looking at one might be interested in the other.

Comment 3

[Jesse Ruderman]

*** Bug 233859 has been marked as a duplicate of this bug. ***

Comment 4

[Met - Martin Hassman]

Attachment: Quick path which works for me.

Because this problem is very unpleasant for me, I have created quick patch for
the Forefox 0.8 version.
I am not Mozilla coder - this in only quick (and may be not correct solution)
but it is working for me and it is very short (changes about 4 lines :-).
If anyone want it - here it is.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

-ing will take patch. 

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

erk. didn't see the patch. +ing to provoke review. 

Comment 7

[Asa Dotzler [:asa]]

p4 priority - not a blocker. if a fully reviewed patch materializes, please
nominate for aviary approval. 

Comment 8

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 9

[Mike Connor [:mconnor]]

Maybe useful, probably not harmful, so Future.

Comment 10

[Shawn Wilsher :sdwilsh]

I don't think special casing things is a good idea, and this is essentially bug 224408 (but with specialization)