1966298 - Port bug 1956634 - Enable <input type="search"> in privileged documents

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Magnus Melin [:mkmelin]]

Bug 1956634 will enabling the clear search button in <input type="search"> for privileged documents.
3 hits atm: https://searchfox.org/comm-central/search?q=type%3D%22search%22&path=mail%2F&case=false&regexp=false

Comment 2

[Martin Giger [:freaktechnik]]

We should be able to influence styles using ::-moz-search-clear-button etc. To test, you can already toggle the layout.forms.input-type-search.enabled pref.

Comment 3

[Magnus Melin [:mkmelin]]

Note that bug 1956634 is incoming (was on autoland but got backed out). Someone should look at this soonish.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Bug 1966298 - Style the -moz-search-clear-button to our needs. r=#thunderbird-front-end-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a2fbf29fd38d
Style the -moz-search-clear-button to our needs. r=freaktechnik

Comment 6

[Geoff Lankow (:darktrojan) [PTO, back 8 Dec]]

I backed this out, it broke a bunch of tests:
https://hg.mozilla.org/comm-central/rev/4a32aab1ad21c651894998ff2eb5d1efc3a363c4

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/75a8a3d50581
Style the -moz-search-clear-button to our needs. r=freaktechnik

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9496210 [details]
Bug 1966298 - Style the -moz-search-clear-button to our needs. r=#thunderbird-front-end-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Bug 1956634 we're depend on is 141.
• User impact if declined: Double clear icons, wrong borders on some search boxes
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: N/A
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): There are smaller changes and the tests are happy.
• String changes made/needed: none

Comment 9

[Corey Bryant]

Comment on attachment 9496210 [details]
Bug 1966298 - Style the -moz-search-clear-button to our needs. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 141.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/8e39e07e3a0b (incorrect commit message, uplifted to 141.0b3, backed out afterwards)
https://hg.mozilla.org/releases/comm-beta/rev/ef7628e2be3a (correct commit message, uplifted after 141.0b3)