1966433 - Implement support for a slotted action buttons and links in moz-promo

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Hanna Jones [:hjones]]

Once we have the basic moz-promo element implemented we'll want to add support for at least one "action" button. We'll also need to make the promo optionally dismissable via a dismissable property/attr. moz-message-bar should provide some prior art that we can draw from here.

Comment 1

[Mark Striemer [:mstriemer]]

Note: dismissable will move to another bug

Acceptance criteria:

• An actions slot is added for the buttons and links
• Story
• Basic tests
• stretch goals:
  • Fun primary buttons are purple
  • Tokens for primary fun buttons are included in design-tokens.json for Figma export

Comment 2

[Tim Giles [:tgiles]]

Attachment: Bug 1966433 - Add actions slot to moz-promo. r=#recomp-reviewers

This patch adds an actions slot to the moz-promo component. In order
to have a slotted moz-button be visible in dark mode, I added some
reasonable dark mode colors to the vibrant promo since these colors are
not finalized.

Since the design is not finalized, I did not match the layout of the UI
to the design for the following case: long heading and body text, image
aligned at the center, element is slotted within actions. This will be
addressed in Bug 1977900.

Comment 3

[Tim Giles [:tgiles]]

Attachment: Bug 1966433 - Add support-link slot to moz-promo. r=#recomp-reviewers

This patch adds a support-link slot to the moz-promo element. Since the
design of moz-promo is not finalized, I did not match the layout of the
UI to the current design. This will be addressed in Bug 1977900.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/db7a9d014477
https://hg.mozilla.org/integration/autoland/rev/481e1ffa8c0b
Add actions slot to moz-promo. r=reusable-components-reviewers,akulyk
https://github.com/mozilla-firefox/firefox/commit/ee7f0aef093f
https://hg.mozilla.org/integration/autoland/rev/6a786dbfdb66
Add support-link slot to moz-promo. r=reusable-components-reviewers,akulyk

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/481e1ffa8c0b
https://hg.mozilla.org/mozilla-central/rev/6a786dbfdb66