Closed
Bug 1978347
Opened 10 months ago
Closed 5 months ago
Fix leftover space when there are no slotted elements in moz-promo
Categories
(Toolkit :: UI Widgets, task, P3)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
148 Branch
| Tracking | Status | |
|---|---|---|
| firefox148 | --- | fixed |
People
(Reporter: tgiles, Assigned: im.sekiel)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp])
Attachments
(2 files)
image.png
When there are no elements in the slot in moz-promo, there is still extra space due to display:flex and gap on the text-container in moz-promo. We had a similar issue with moz-message-bar and so we'll need to implement something like adding a .active class to prevent the extra space.
Acceptance Criteria:
- The empty slot in moz-promo does not take up any space within the component
- The slot renders correctly when elements are added to it
|
||
Updated•10 months ago
|
Hi everyone, I will look into this bug and if I have any questions I'll ask here. Thanks.
|
||
Updated•5 months ago
|
Assignee: nobody → im.sekiel
Status: NEW → ASSIGNED
Pushed by tgiles@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/f0361e4a5f69
https://hg.mozilla.org/integration/autoland/rev/b3021bc96d2b
Fix leftover space when there are no slotted elements in moz-promo. r=tgiles,desktop-theme-reviewers
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox148:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 148 Branch
|
||
Updated•4 months ago
|
QA Whiteboard: [qa-triage-done-c149/b148]
You need to log in
before you can comment on or make changes to this bug.
Description
•