Closed Bug 1966670 Opened 3 months ago Closed 3 months ago

Two share buttons when using the tabstrip

Categories

(Firefox for Android :: Toolbar, defect, P2)

All
Android
defect

Tracking

()

RESOLVED FIXED
140 Branch
Tracking Status
firefox138 --- unaffected
firefox139 --- unaffected
firefox140 --- fixed

People

(Reporter: petru, Assigned: petru)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Attached image image.png

Steps to reproduce

  1. Visit any website on a large screen device with the tabstrip feature enabled

Expected behavior

See only one share button, outside of the URL box

Actual behavior

There are two share buttons, one more inside the URL box

This restores the previous behavior and ensures there will only be one share button.
(to rule them all)

Attached image Cause for the bug.png

Seems like this was caused when removing the navbar by a reversed condition for adding a share button as a page action.

Set release status flags based on info from the regressing bug 1961852

Pushed by plingurar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4ad3372857d5 Don't show a share page action if the tabstrip is enabled r=android-reviewers,skhan

This matcher will need updating as there's now the "Share" child (to prevent androidx.test.espresso.AmbiguousViewMatcherException) . I'll post up a patch.

https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/robots/NavigationToolbarRobot.kt#654

Regressions: 1966762
Regressions: 1966765
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: