Closed
Bug 1966670
Opened 3 months ago
Closed 3 months ago
Two share buttons when using the tabstrip
Categories
(Firefox for Android :: Toolbar, defect, P2)
Tracking
()
RESOLVED
FIXED
140 Branch
Tracking | Status | |
---|---|---|
firefox138 | --- | unaffected |
firefox139 | --- | unaffected |
firefox140 | --- | fixed |
People
(Reporter: petru, Assigned: petru)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
Steps to reproduce
- Visit any website on a large screen device with the tabstrip feature enabled
Expected behavior
See only one share button, outside of the URL box
Actual behavior
There are two share buttons, one more inside the URL box
Assignee | ||
Comment 1•3 months ago
|
||
This restores the previous behavior and ensures there will only be one share button.
(to rule them all)
Assignee | ||
Comment 2•3 months ago
|
||
Seems like this was caused when removing the navbar by a reversed condition for adding a share button as a page action.
Comment 3•3 months ago
|
||
Set release status flags based on info from the regressing bug 1961852
status-firefox140:
--- → affected
Pushed by plingurar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ad3372857d5
Don't show a share page action if the tabstrip is enabled r=android-reviewers,skhan
Comment 5•3 months ago
|
||
This matcher will need updating as there's now the "Share" child (to prevent androidx.test.espresso.AmbiguousViewMatcherException
) . I'll post up a patch.
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•