1961852 - [Toolbar redesign] Remove toolbar redesign layout code.

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task)

Description

[Roger Yang [:royang]]

In preparation to add toolbar redesign toolbar code to compose, remove related toolbar layout code.

Comment 1

[Roger Yang [:royang]]

Attachment: WIP: Bug 1961852 - Disable and remove toolbar redesign.

The plan here is to remove anything that allows the user to enable toolbar redesign since we are re-implementing that in compose.

Comment 2

[Roger Yang [:royang]]

Attachment: Bug 1961852 - Disable and remove toolbar redesign.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2422840ce11d
Disable and remove toolbar redesign. r=android-reviewers,petru,android-l10n-reviewers,delphine

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8277edf12423
Revert "Bug 1961852 - Disable and remove toolbar redesign. r=android-reviewers,petru,android-l10n-reviewers,delphine" for causing fenix opt failures in BrowserJourneyBaselineProfileGenerator.

Comment 5

[amarc]

Backed out for causing fenix opt failures in BrowserJourneyBaselineProfileGenerator

• Backout link
• Push with failures
• Failure Log

Comment 6

[Roger Yang [:royang]]

(In reply to amarc from comment #5)

Backed out for causing fenix opt failures in BrowserJourneyBaselineProfileGenerator

• Backout link
• Push with failures
• Failure Log

Thanks, I'll try again to land it with fix in BrowserJourneyBaselineProfileGenerator. Unfortunately this test was not part of the precommit test. I will work with implementer to make sure this is part of the fenix preset try.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3426229ed834
Disable and remove toolbar redesign. r=android-reviewers,petru,android-l10n-reviewers,delphine

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c589571aea0e
Revert "Bug 1961852 - Disable and remove toolbar redesign. r=android-reviewers,petru,android-l10n-reviewers,delphine" for causing fenix bpgo failures @ LaunchIntentBaselineProfileGenerator

Comment 9

[amarc]

Backed out for causing fenix bpgo failures @ LaunchIntentBaselineProfileGenerator

• Backout link
• Push with failures
• Failure Log

Comment 10

[Roger Yang [:royang]]

Thanks again. Unfortunately those tests are flaky and I was passing consistently locally. I've created issues to track it and added @ignore and will try to land this change again. Sorry about this.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cde666e7966
Disable and remove toolbar redesign. r=android-reviewers,petru,android-l10n-reviewers,delphine

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3cde666e7966

Comment 13

[Markus Stange [:mstange]]

(In reply to Roger Yang [:royang] from comment #10)

Thanks again. Unfortunately those tests are flaky and I was passing consistently locally. I've created issues to track it and added @ignore and will try to land this change again. Sorry about this.

Can you please link the issues you filed?

Comment 14

[Roger Yang [:royang]]

These are the issues created Bug 1964970 and Bug 1965004

Comment 15

[Florin Bilt]

(In reply to Cosmin Sabou [:CosminS] from comment #12)

https://hg.mozilla.org/mozilla-central/rev/3cde666e7966

Perfherder has detected a mozperftest performance change from push 3cde666e79666af24391c4befbed34ece8aba58e.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
79%	background-resource cpuTime-gpu-background-diff	android-hw-a55-14-0-aarch64-shippable		27.20 -> 5.83
73%	background-resource cpuTime-tab-50%	android-hw-a55-14-0-aarch64-shippable		5,606.67 -> 1,530.00
68%	background-resource cpuTime-tab-10%	android-hw-a55-14-0-aarch64-shippable		4,711.60 -> 1,509.17
68%	background-resource cpuTime-tab-50%	android-hw-a55-14-0-aarch64-shippable		5,540.40 -> 1,782.50
68%	background-resource cpuTime-tab-start	android-hw-a55-14-0-aarch64-shippable		3,482.80 -> 1,124.17

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 45156

The following documentation link provides more information about this command.