1966951 - Add rest of icons for new profile avatar selector

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[Niklas Baumgardner [:niklas] PTO until 9-15]

See engineering doc for description of bug.

Comment 1

[Teddy Bersentes]

Attachment: Bug 1966951 - Add all profile avatar icons into profile avatar selector r=#profiles-reviewers

Comment 2

[Teddy Bersentes]

Attachment: Bug 1966161 - Save circular image in custom profile avatar selector r=#profiles-reviewers

Comment 3

[Phabricator Automation]

Comment on attachment 9494144 [details]
Bug 1966161 - Save circular image in custom profile avatar selector r=#profiles-reviewers

Revision D253370 was moved to bug 1966161. Setting attachment 9494144 [details] to obsolete.

Comment 4

[Phabricator Automation]

Comment on attachment 9494144 [details]
Bug 1966161 - Save circular image in custom profile avatar selector r=#profiles-reviewers

Revision D253370 was moved to bug 1966161. Setting attachment 9494144 [details] to obsolete.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

I'm a bit confused, but might be missing something... why do we need different size variants for all these svgs? Shouldn't we be able to just use one (let's say, the 80 one) and scale it as needed? An 80x80 SVG can be drawn at 16x16 without any issue...

Comment 6

[Niklas Baumgardner [:niklas] PTO until 9-15]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

I'm a bit confused, but might be missing something... why do we need different size variants for all these svgs? Shouldn't we be able to just use one (let's say, the 80 one) and scale it as needed? An 80x80 SVG can be drawn at 16x16 without any issue...

The last few comments in D252385 talk about this. We only need two sizes for each avatar. One where the avatar is simplified for displaying at small sizes and one with more detail for everything else.

I filed bug 1973245 to address this and remove the icons.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fa86cc8ccd51
https://hg.mozilla.org/integration/autoland/rev/2c1c8b236d86
Add all profile avatar icons into profile avatar selector r=profiles-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,jhirsch,niklas,sfoster

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6d6b178eaa11
https://hg.mozilla.org/integration/autoland/rev/f3462d7e5e69
Revert "Bug 1966951 - Add all profile avatar icons into profile avatar selector r=profiles-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,jhirsch,niklas,sfoster" for causing high frequency failures at browser_custom_avatar_test.js.

Comment 9

[Atila Butkovits]

Backed out for causing high frequency failures at browser_custom_avatar_test.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/f3462d7e5e69cf55f82a34ebbd2cdb199920bd0f

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c2a657f761cba08222b1174606f06b84d34b70e9

Failure log: https://treeherder.mozilla.org/logviewer?job_id=515873561&repo=autoland&lineNumber=12182

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/39f730bcc6f2
https://hg.mozilla.org/integration/autoland/rev/c3b799ca0132
Add all profile avatar icons into profile avatar selector r=profiles-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,jhirsch,niklas,sfoster

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/406238009d4f
https://hg.mozilla.org/integration/autoland/rev/08a110d7f4cf
Revert "Bug 1966951 - Add all profile avatar icons into profile avatar selector r=profiles-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,jhirsch,niklas,sfoster" for causing bc failures on browser_custom_avatar_test.js.

Comment 12

[Iulian Moraru]

Revert for causing bc failures on browser_custom_avatar_test.js.

• Push with failures

• Failure log

• Backout link

[task 2025-07-03T19:48:53.639+00:00] 19:48:53     INFO - TEST-PASS | browser/components/profiles/tests/browser/browser_custom_avatar_test.js | Should have a profile now - {} == true - 
[task 2025-07-03T19:48:53.640+00:00] 19:48:53     INFO - Buffered messages finished
[task 2025-07-03T19:48:53.641+00:00] 19:48:53     INFO - TEST-UNEXPECTED-FAIL | browser/components/profiles/tests/browser/browser_custom_avatar_test.js | Uncaught exception in test bound test_avatar_selector_tabs - at chrome://browser/content/profiles/edit-profile-card.mjs:106 - TypeError: can't access property "childElements", this.themesPicker is null
[task 2025-07-03T19:48:53.641+00:00] 19:48:53     INFO - Stack trace:
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - get themeCards@chrome://browser/content/profiles/edit-profile-card.mjs:106:5
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - getUpdateComplete@chrome://browser/content/profiles/edit-profile-card.mjs:179:18
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - async*get updateComplete@chrome://global/content/vendor/lit.all.mjs:898:21
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - @chrome://mochitests/content/browser/browser/components/profiles/tests/browser/browser_custom_avatar_test.js:260:9
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - execute@resource://testing-common/SpecialPowersSandbox.sys.mjs:139:12
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - _spawnTask@resource://testing-common/SpecialPowersChild.sys.mjs:1616:15
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - receiveMessage@resource://testing-common/SpecialPowersChild.sys.mjs:256:21
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - JSActor query*receiveMessage@resource://testing-common/SpecialPowersParent.sys.mjs:1400:14
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - JSActor query*spawn@resource://testing-common/SpecialPowersChild.sys.mjs:1543:17
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - test_avatar_selector_tabs/<@chrome://mochitests/content/browser/browser/components/profiles/tests/browser/browser_custom_avatar_test.js:255:27
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - withNewTab@resource://testing-common/BrowserTestUtils.sys.mjs:121:22
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - async*test_avatar_selector_tabs@chrome://mochitests/content/browser/browser/components/profiles/tests/browser/browser_custom_avatar_test.js:249:26
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1212:26
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1288:18
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1429:14
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1194:14
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2025-07-03T19:48:53.642+00:00] 19:48:53     INFO - Leaving test bound test_avatar_selector_tabs
[task 2025-07-03T19:48:55.491+00:00] 19:48:55     INFO - GECKO(7641) | [Child 7782: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fbb9c353000 == 1 [pid = 7782] [id = 0] [url = about:blank]
[task 2025-07-03T19:48:55.553+00:00] 19:48:55     INFO - GECKO(7641) | [Child 7782: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (7fbb9bccaa00) [pid = 7782] [serial = 1] [outer = 0] [url = about:blank]
[task 2025-07-03T19:48:55.996+00:00] 19:48:55     INFO - GECKO(7641) | MEMORY STAT | vsize 11691MB | residentFast 673MB | heapAllocated 304MB
[task 2025-07-03T19:48:55.996+00:00] 19:48:55     INFO - TEST-OK | browser/components/profiles/tests/browser/browser_custom_avatar_test.js | took 4944ms
[task 2025-07-03T19:48:56.010+00:00] 19:48:56     INFO - GECKO(7641) | [Child 7827: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fbb9c35c800 == 2 [pid = 7827] [id = 1]
[task 2025-07-03T19:48:56.010+00:00] 19:48:56     INFO - GECKO(7641) | [Child 7827: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (7fbb9bcbfe00) [pid = 7827] [serial = 3] [outer = 0]
[task 2025-07-03T19:48:56.011+00:00] 19:48:56     INFO - GECKO(7641) | [Child 7827: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (7fbbb2da8b00) [pid = 7827] [serial = 4] [outer = 7fbb9bcbfe00]
[task 2025-07-03T19:48:56.044+00:00] 19:48:56     INFO - checking window state
[task 2025-07-03T19:48:56.083+00:00] 19:48:56     INFO - TEST-START | browser/components/profiles/tests/browser/browser_delete_profile_page_test.js.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/153dbd70567d
https://hg.mozilla.org/integration/autoland/rev/04aaccfea7f5
Add all profile avatar icons into profile avatar selector r=profiles-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,jhirsch,niklas,sfoster

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f23d879ad293
https://hg.mozilla.org/integration/autoland/rev/fd491d5224c3
Revert "Bug 1966951 - Add all profile avatar icons into profile avatar selector r=profiles-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,jhirsch,niklas,sfoster" for causing bc failures @ browser_custom_avatar_test.js

Comment 15

[amarc]

Backed out for causing bc failures @ browser_custom_avatar_test.js

• Backout link
• Push with failures
• Failure Log

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/807e60afe6a9
https://hg.mozilla.org/integration/autoland/rev/7bcf659282ab
Add all profile avatar icons into profile avatar selector r=profiles-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,jhirsch,niklas,sfoster

Comment 17

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7bcf659282ab