1977144 - custom-avatar-alt was changed without a new ID, causing failure in l10n infra

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect, P1)

Description

[Francesco Lodolo [:flod]]

https://phabricator.services.mozilla.com/D252385

This changed

custom-avatar-alt =
    .alt = Custom avatar

To

custom-avatar-alt = Custom

My local instance of Pontoon committed just this

custom-avatar-alt = 

Luckily only Italian was affected so far, but this means that quarantine is blocked.

The string ID needs to be changed (that's this bug). But there's a bug in our infrastructure, because Pontoon shouldn't have committed that translation in the first place.

@eemeli
Can you file a separate bug in the right place? Not sure if Pontoon or moz-l10n. Apparently Pontoon is in a state where it only knows about the string's version with alt attribute, even a forced sync won't change that.

Treeherder link: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=l10n&fromchange=6e1a18e207d8fc76de10a2f61f59a908c9133757&tochange=e4a1f24183370c53e6e9d937f4d3dd5ba064ad74&selectedTaskRun=ZX95FIDiS2Sx136n-gN-pg.0

Revert link: https://hg.mozilla.org/integration/autoland/rev/e4a1f24183370c53e6e9d937f4d3dd5ba064ad74

Failure log: https://treeherder.mozilla.org/logviewer?job_id=517742526&repo=autoland

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1966951

Comment 2

[Eemeli Aro [:eemeli]]

For moz.l10n, https://github.com/mozilla/moz-l10n/pull/91 should fix its part of the issue, as such an empty message should be serialized as

custom-avatar-alt = { "" }

to make it valid Fluent.

I'm keeping the needinfo on, as at least some work is required in Pontoon as well.

Comment 3

[Eemeli Aro [:eemeli]]

It looks like Pontoon will need an update once the moz.l10n PR lands and a new release is available. Regarding its general behaviour in a case like this, I added pontoon#3718. The related oddity in the firefox-l10n-source scripts ought to get cleared up by updating its moz.l10n dependency to its latest version.

Comment 4

[❌ PTO, back 8/18 ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hey :eemeli, do we need to update the strings that surfaced this bug?

Comment 5

[Eemeli Aro [:eemeli]]

Yes, for two reasons:

1. I'm pretty sure that it was a mistake for custom-avatar-alt to not have its value in the .alt attribute. All of the other *-avatar-alt strings use an .alt attribute, and it's used as the l10n-id of an <img> element, which ought not have any contents.
2. The string content changes from "Custom avatar" to "Avatar", so the message ought to have a new l10n id like custom-avatar-alt-2.

Comment 6

[❌ PTO, back 8/18 ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Thanks, we're on it.

Comment 7

[Teddy Bersentes]

Attachment: Bug 1977144 - Fix custom-avatar-alt localization format to use alt attribute

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5256c5c80ac8
https://hg.mozilla.org/integration/autoland/rev/d73f173c9fa5
Fix custom-avatar-alt localization format to use alt attribute r=jhirsch,fluent-reviewers,bolsson

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/d73f173c9fa5