1966979 - The radio items in the pop-up menu do not display checkmarks

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[nayinain]

Attachment: Screenshots.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:140.0) Gecko/20100101 Firefox/140.0

Steps to reproduce:

1. Open the AI Chatbot sidebar.
2. Click the three-dot button.

Actual results:

Should display checkmarks

Expected results:

---

Sorry for my bad English.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Machine Learning' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[nayinain]

Regression Window:

2025-05-17T00:49:59.128000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg-edge.mozilla.org
2025-05-17T00:50:01.455000: DEBUG : urllib3.connectionpool: https://hg-edge.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=9a34891d4ce50b5634232cd41b2e8ab390a23887&full=1 HTTP/11" 200 None
2025-05-17T00:50:01.507000: DEBUG : Found commit message:
Bug 1966100 - Unify gutter implementation between Linux and Windows. r=desktop-theme-reviewers,dao

No behavior change, because the numbers happened to add up. But we were
relying on the 12px being the default menu font-size (as otherwise the
arrow would be off).

Show the (empty) icons, rather than compensating with padding. That's
more reliable.

Differential Revision: https://phabricator.services.mozilla.com/D249072

2025-05-17T00:50:01.507000: DEBUG : Did not find a branch, checking all integration branches
2025-05-17T00:50:01.514000: INFO : The bisection is done.
2025-05-17T00:50:01.518000: INFO : Stopped

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1966100, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

The good rendering wasn't even good, it was working by chance.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1966979 - Set type=checkbox properly on genai menuitems. r=#firefox-ai-ml-reviewers,#theme

Comment 6

[Emilio Cobos Álvarez [:emilio]]

On Linux this has always been broken afaict.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89ac20964efb
Set type=checkbox properly on genai menuitems. r=firefox-ai-ml-reviewers,Mardak

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/89ac20964efb

Comment 10

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Firefox Nightly 140.0a1 build, from 2025-05-16, using Windows 11, as described in Comment 0.
Verified as fixed using Firefox 140.0b2, on Windows 11, macOS 14 and Ubuntu 22.04. The Show/Hide options from the AI Chatbot sidebar menu display the checkmarks.