1967617 - Replace individual `Geoname::admin{level}_code` properties with one `admin_division_codes` map

Status: RESOLVED FIXED

(Application Services :: Suggest, task, P1)

Description

[Drew Willcoxon :adw]

I'd like to replace the individual Geoname::admin{level}_code properties with a single admin_division_codes map. A few reasons:

• I'm working on another patch that adds a way for consumers to fetch localized/alternate names for geonames, including alternates for a geoname's admin divisions. I'm introducing another struct for that, and I don't want to repeat admin{level}_name for each level in that struct.
• I like the idea of not baking the max number of levels into the public API.
• Not a big deal, but using a map would be similar to the object that AccuWeather returns for locations, although it returns an array of objects instead of one object.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/application-services] Bug 1967617 - Replace individual `Geoname::admin{level}_code` properties with one `admin_division_codes` map (#6758)

Comment 2

[BMO Github Automation]

Authored by https://github.com/0c0w3
https://github.com/mozilla/application-services/commit/1362582f152d3f97fd15b5ce8e5bcbfbc02e5abe
[main] Bug 1967617 - Replace individual Geoname::admin{level}_code properties with one admin_division_codes map

Comment 3

[Drew Willcoxon :adw]

This was vendored in bug 1968156.