1968076 - no loading-animation of ANY kind appearing behind "Cookies and site data" and "Temporary cached files and pages" in clear history menu while Fx is calculating data size of both entries

Status: VERIFIED FIXED

(Toolkit :: Data Sanitization, enhancement, P3)

Description

[Dan [:dan23]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:138.0) Gecko/20100101 Firefox/138.0

Steps to reproduce:

Hit Ctrl+Shift+Del on keyboard (with a entirely average amount of cache-data in your Fx profile, for example 1-2 GB of "cookies and site data" and 1 GB of "temporary cached files").

Actual results:

Window appears, then after 3-8 seconds the data size for both fields suddenly appear

Expected results:

There should be ANY kind of tiny/small animation behind those fields to indicate to the user that size-data is being calculated UNTIL the sizes appear and replace the animated "loading"-icons (even on SSDs these can take up to 10 (TEN) seconds!!)

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Performance: General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:bas.schouten, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Bas Schouten (:bas.schouten)]

Not sure what the right component is for this so putting it in tabbed browser, hopefully they can move it to the right place.

Comment 4

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:jswinarton, could you have a look please?

For more information, please visit BugBot documentation.

Comment 5

[Jeremy Swinarton]

The file that drives this modal is here: https://searchfox.org/firefox-main/source/browser/base/content/sanitizeDialog.js

I'm not sure if there is a better place for this, but it's not a tabbed browser issue. Setting to general for now.

Comment 6

[Harshit Sohaney [:hsohaney]]

This is expected behavior, but a great enhancement! The current behavior renders the data sizes once they are calculated, but a simple loading option would be great, although I'm unsure how these are usually communicated to the user. Would probably benefit from some UX input.

Comment 7

[Dan [:dan23]]

(In reply to Harshit Sohaney [:hsohaney] from comment #6)

This is expected behavior, but a great enhancement! The current behavior renders the data sizes once they are calculated, but a simple loading option would be great, although I'm unsure how these are usually communicated to the user. Would probably benefit from some UX input.

"loading option"? You mean loading indicator/indication, or? A spinner (like the infamous Tab Spinner xD) would be so simple but sooo useful!

Comment 8

[Harshit Sohaney [:hsohaney]]

Yes, any form of indication of loading would be great!

Comment 9

[Dan [:dan23]]

Let's simply use the Firefox loader SVG chrome://global/skin/icons/loading.svg, that icon is already included and fits quite well, or?

Comment 10

[Dan [:dan23]]

Or even better, either of these two, spinner or throbber:
https://searchfox.org/firefox-release/source/browser/extensions/newtab/data/content/assets/spinner.svg
https://searchfox.org/firefox-release/source/toolkit/themes/shared/media/throbber.png

Comment 11

[James Han]

Attachment: Bug 1968076 - Add loading indicator while calculating data sizes in clear history dialog. r?manuel

Show animated loading spinners next to 'Cookies and site data' and 'Temporary cached files'
checkboxes while data sizes are being calculated. The spinners appear immediately when the
dialog opens and are hidden once the size calculation completes.

This provides visual feedback to users during the 3-10 second calculation period, addressing
the UX issue where users had no indication that the browser was working.

Comment 12

[Dan [:dan23]]

Awesome, thanks! Would you be interested to add a tiny easteregg into this feature, that when setting a (then new) boolean pref //(like "privacy.sanitize.RetroTabSpinnerEasteregg" or "privacy.clearHistory.RetroTabSpinnerEasteregg" or so to "true"?)// that it would use the very (in)famous 2KB tab spinner from 2021 ? :) ( file at https://searchfox.org/firefox-main/source/toolkit/components/pdfjs/content/web/images/loading-icon.gif )

Comment 13

[James Han]

(In reply to Dan from comment #12)

Awesome, thanks! Would you be interested to add a tiny easteregg into this feature, that when setting a (then new) boolean pref //(like "privacy.sanitize.RetroTabSpinnerEasteregg" or "privacy.clearHistory.RetroTabSpinnerEasteregg" or so to "true"?)// that it would use the very (in)famous 2KB tab spinner from 2021 ? :) ( file at https://searchfox.org/firefox-main/source/toolkit/components/pdfjs/content/web/images/loading-icon.gif )

Yes this sound interesting, I will try something out!

Comment 14

[Dan [:dan23]]

(In reply to James Han from comment #13)

(In reply to Dan from comment #12)

Awesome, thanks! Would you be interested to add a tiny easteregg into this feature, that when setting a (then new) boolean pref //(like "privacy.sanitize.RetroTabSpinnerEasteregg" or "privacy.clearHistory.RetroTabSpinnerEasteregg" or so to "true"?)// that it would use the very (in)famous 2KB tab spinner from 2021 ? :) ( file at https://searchfox.org/firefox-main/source/toolkit/components/pdfjs/content/web/images/loading-icon.gif )

Yes this sound interesting, I will try something out!

No progress so far, or?

Comment 15

[Manuel Bucher [:manuel]]

Regarding the easter egg: I adviced against it due to us already having too many prefs and the slim benefit of introducing another one for this patch.

Comment 16

[James Han]

(In reply to Dan from comment #14)

(In reply to James Han from comment #13)

(In reply to Dan from comment #12)

Awesome, thanks! Would you be interested to add a tiny easteregg into this feature, that when setting a (then new) boolean pref //(like "privacy.sanitize.RetroTabSpinnerEasteregg" or "privacy.clearHistory.RetroTabSpinnerEasteregg" or so to "true"?)// that it would use the very (in)famous 2KB tab spinner from 2021 ? :) ( file at https://searchfox.org/firefox-main/source/toolkit/components/pdfjs/content/web/images/loading-icon.gif )

Yes this sound interesting, I will try something out!

No progress so far, or?

Yep, I discussed with Manuel and we decided to ship the animation as is due to too many prefs.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f01350ee365a
https://hg.mozilla.org/integration/autoland/rev/76e06976e33e
Add loading indicator while calculating data sizes in clear history dialog. r=manuel,desktop-theme-reviewers,fluent-reviewers,bolsson,sfoster

Comment 18

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/76e06976e33e

Comment 19

[Dan [:dan23]]

Thx for the fix! Well done!