Remove all old clear data dialog boxes
Categories
(Toolkit :: Data Sanitization, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox149 | --- | fixed |
People
(Reporter: hsohaney, Assigned: jhan)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Once the new clear history dialog is shipped, and there are no underlying issues wherein users are having to switch to the old dialog, we can remove the old clear history dialog completely
|
Reporter | |
Updated•2 years ago
|
|
||
Comment 1•1 year ago
|
||
This does not mean removing the privacy.sanitize.useOldClearHistoryDialog pref, right?
|
|
Reporter | |
Comment 2•1 year ago
|
||
Yes it means to remove the old dialog along with the pref to switch back to it. If this is no longer something the team wants to do, we can remove this bug!
|
|
||
Comment 3•1 year ago
|
||
Yes. Why would a user even always want to delete his entire form history along with the browsing history?
|
|
Reporter | |
Comment 4•1 year ago
|
||
Got it, thanks for confirming. The intention is indeed to remove the old dialog along with the preference to switch back to it, provided the new dialog addresses all the key concerns.
However, the current feedback suggests that some users revert to the old dialog because:
- The new dialog lacks an advanced options tab, where users could clear data in a more granular manner.
- There's no separate option to clear form data without deleting browsing history.
Given the numerous related bug reports and requests, these seem to be important functionalities for users.
Would it make sense to revisit the timeline for removing the old dialog until these gaps are addressed? Or should this bug be closed if the team decides that switching back is no longer supported regardless?
If we don't run into technical reasons to remove it, we should keep the preference for now until we address user concerns with the new dialogue. Thanks!
The old clear history dialog (sanitize.xhtml) and the preference
privacy.sanitize.useOldClearHistoryDialog have been fully removed.
The new dialog (sanitize_v2.xhtml) is now the only clear data dialog.
Removed:
- Old dialog UI files (sanitize.xhtml, clearSiteData.xhtml, sanitize.js, clearSiteData.js)
- Old dialog tests (browser_sanitizeDialog.js, test_Sanitizer_interrupted.js, etc.)
- privacy.sanitize.useOldClearHistoryDialog preference from StaticPrefList.yaml and firefox.js
Updated:
- sanitizeDialog.js and Sanitizer.sys.mjs: removed all old dialog conditional branches
- privacy.js: removed old dialog selection logic
- CacheObserver.h: removed C++ check for old dialog preference
- Test files: removed old dialog preference settings
- Test manifests: removed old test entries
- Build manifests (jar.mn): removed old dialog files from packaging
All tests pass with the new dialog as the only option.
|
||
Updated•10 months ago
|
|
|
||
Comment 7•10 months ago
|
||
James, could you also add an animated loading indicator (as simple as possible) for optimal UX, do you have time for that before this change affects Fx Beta builds? (As I mentioned in Bug 1968076#c10 nearly half a year ago)
|
||
Comment 10•8 months ago
•
|
||
Backed out for causing bc failures @ sanitizeDialog.css
Backout link: https://hg.mozilla.org/integration/autoland/rev/1aa1c27506eaec16664ec53c1c6fb3d939e919a5
|
||
Comment 11•8 months ago
|
||
| Comment hidden (advocacy) |
|
|
||
Updated•8 months ago
|
|
|
Reporter | |
Comment 13•8 months ago
|
||
The Animation is non blocking for this bug (from what I understand). The animation would be a nice to have, but not necessarily a need. From the bug activity, it looks like there is some activity there already!
|
|
Reporter | |
Comment 14•8 months ago
|
||
Actually, looking at the code here, shouldn't the pref also be removed from these Backup components too? https://searchfox.org/firefox-main/search?q=useOldClearHistoryDialog&path=backup&case=false®exp=false
|
||
Comment 15•8 months ago
|
||
| bugherder | ||
|
|
||
Comment 16•8 months ago
|
||
149 as target milestone, thank god, we still have time to add the animation. Harshit, there has been no activity in that other bug for many many weeks now... ;( Are you able to add such animation? Or at least a string "calculating size..." behind them until they finished calculating?
|
||
Comment 17•8 months ago
•
|
||
(In reply to Dan from comment #16)
149 as target milestone, thank god, we still have time to add the animation. Harshit, there has been no activity in that other bug for many many weeks now... ;( Are you able to add such animation? Or at least a string "calculating size..." behind them until they finished calculating?
@Dan: Don't worry. The patch on Bug 1968076 is ready to land and intended to land within the same release cycle as this one. Sorry for not communicating that more clearly. I'm certain we will be able to have it stick within the 3 weeks window we have for 149.
Trying to land it now.
|
|
||
Comment 18•8 months ago
|
||
excellent!
Trying to land it now.
Thanks!!
|
Assignee | |
Comment 19•8 months ago
|
||
Just submitted a patch to remove the additional references to old dialog.
@Dan: regarding the loading animation, it is landing right now, will keep you updated.
Description
•