1968265 - Update android nightly application-services version bump to new version acb87bfc59ced0a6fcb23c8d231bd5f690fc76ed from 2025-05-23 14:04:05

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement)

Description

[Update Bot]

This update covers 7 commits, including 1 new upstream commit I've never filed a bug on before. (It's the top one.). Here are the overall diff statistics, and then the commit information.

---

mobile/android/android-components/plugins/dependencies/src/main/java/ApplicationServices.kt | 2 +-
mobile/android/android-components/plugins/dependencies/src/main/java/moz.yaml | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

---

acb87bfc59ced0a6fcb23c8d231bd5f690fc76ed by Ryan VanderMeulen <[e-mail]>

https://github.com/mozilla/application-services/commit/acb87bfc59ced0a6fcb23c8d231bd5f690fc76ed
Authored: 2025-05-23 08:46:54 -0400
Committed: 2025-05-23 13:21:48 +0000

Update Glean to v64.3.1

Files Modified:

• CHANGELOG.md
• components/external/glean
• gradle/libs.versions.toml
• megazords/ios-rust/Package.resolved
• megazords/ios-rust/Package.swift

---

8986582d377eac7b64bddec8aa9c5ce06b161424 by Drew Willcoxon <[e-mail]>

https://github.com/mozilla/application-services/commit/8986582d377eac7b64bddec8aa9c5ce06b161424
Authored: 2025-05-22 17:34:21 -0700
Committed: 2025-05-23 04:08:07 +0000

Bug 1967899 - Add a way for consumers to fetch localized names and other alternates for geonames

This adds a fetch_geoname_alternates function that returns a struct containing
localized names and other alternates for a geoname, its country, and its admin
divisions.

It also changes the RS schema for alternates records: Each alternate can now be
a string (as before) or an object with is_preferred and is_short booleans.
These bools come straight from the geonames data, and we use them to help decide
which alternates to return from fetch_geoname_alternates.

Files Modified:

• components/suggest/src/geoname.rs
• components/suggest/src/schema.rs
• components/suggest/src/store.rs
• components/suggest/src/weather.rs

---

c447d7386bbe404cd9ca38f5b518c050e64f7d67 by Drew Willcoxon <[e-mail]>

https://github.com/mozilla/application-services/commit/c447d7386bbe404cd9ca38f5b518c050e64f7d67
Authored: 2025-05-22 17:28:26 -0700
Committed: 2025-05-23 03:02:33 +0000

Bug 1967867 - Unify keywords metrics logic

• Change the keywords_metrics table so it's based on record types instead of
  providers. Geonames keywords don't map to a provider but everything maps to a
  record type.
• Update the geonames implementation so it uses keywords_metrics and get rid
  of geonames_metrics.
• Add KeywordsMetricsUpdater and KeywordsMetrics helpers.
• Update GeonameCache and WeatherCache so they keep a KeywordsMetrics.
• Remove max_keyword_length and max_keyword_word_count from the weather
  record since those values are computed by KeywordsMetricsUpdater now.

Files Modified:

• components/suggest/src/db.rs
• components/suggest/src/geoname.rs
• components/suggest/src/rs.rs
• components/suggest/src/schema.rs
• components/suggest/src/weather.rs

---

1362582f152d3f97fd15b5ce8e5bcbfbc02e5abe by Drew Willcoxon <[e-mail]>

https://github.com/mozilla/application-services/commit/1362582f152d3f97fd15b5ce8e5bcbfbc02e5abe
Authored: 2025-05-22 17:19:57 -0700
Committed: 2025-05-23 01:47:06 +0000

Bug 1967617 - Replace individual Geoname::admin{level}_code properties with one admin_division_codes map

This replaces the individual Geoname::admin{level}_code properties with a
single admin_division_codes map. A few reasons:

• I'm working on another patch that adds a way for consumers to fetch
  localized/alternate names for geonames, including alternates for a geoname's
  admin divisions. I'm introducing another struct for that, and I don't want to
  repeat admin{level}_name for each level in that struct.
• I like the idea of not baking the max number of levels into the public API.
• Not a big deal, but a map is similar to how AccuWeather's location API handles
  admin divisions, although it uses an array of objects instead of one object.

Files Modified:

• components/suggest/src/benchmarks/geoname.rs
• components/suggest/src/geoname.rs

---

c79865837bace1dfbc56b0383817a131e41bb22c by Drew Willcoxon <[e-mail]>

https://github.com/mozilla/application-services/commit/c79865837bace1dfbc56b0383817a131e41bb22c
Authored: 2025-05-22 17:02:22 -0700
Committed: 2025-05-23 00:38:08 +0000

Bug 1958992 - suggest: Improve geonames l10n and weather-suggestions matching.

This is a substantial reworking of geonames and weather suggestions in suggest.

Summary of major changes:

In RS, don't store geonames' alternate names inline with the core geonames data.
Instead, use separate record types. (As a reminder, "alternates" just means
variants of a geoname's main name, like "NYC" and "NY" are alternates for New
York City.) So now there are two record types: core geonames data and
alternates. The core records contain the main geonames data: IDs, canonical
name, country, admin divisions, etc., and they can be ingested by all clients
regardless of their locale or country. The alternates records are scoped by
language and are intended to be ingested only by clients with matching locales.

Improve geonames fetching and weather-suggestion matching so all admin levels
and countries are supported. e.g., "waterloo on", "waterloo canada", "waterloo
on canada", etc.

Relax the weather parsing a little to allow multiple weather keywords ("rain
weather").

Keep track of all available admin codes per geoname. There are four of them.
This is necessary because a lot of countries outside North America have multiple
admin levels, and determining whether a given geoname is related to another one
requires comparing their admin codes.

Instead of manually computing name variants and inserting them separately into
the DB, use a custom Sqlite collating sequence. ("Variants" here means removing
punctuation, lowercasing, removing diacritics, etc.)

Store each geoname's ascii_name as an alternate. That's useful for chars like
"ö", which is represented as "oe" in the ASCII name (at least the geonames data
I've seen).

Minor changes:

Store latitude and longitude and strings instead of floats. I made this change
to derive Eq for Geoname, but it makes sense anyway and is how I should have
done it originally.

Add Geoname::geoname_type so consumers can easily understand whether it's a
city, admin region, or country.

Remove the geoname_type param from fetch_geonames. Consumers can filter out
matching geonames that they don't want instead.

Files Modified:

• Cargo.lock
• components/suggest/Cargo.toml
• components/suggest/src/benchmarks/geoname.rs
• components/suggest/src/db.rs
• components/suggest/src/geoname.rs
• components/suggest/src/lib.rs
• components/suggest/src/provider.rs
• components/suggest/src/rs.rs
• components/suggest/src/schema.rs
• components/suggest/src/store.rs
• components/suggest/src/suggestion.rs
• components/suggest/src/weather.rs

---

432aa60735509ca5a860e4dcf993c427cbb44ef3 by Temisan Iwere <[e-mail]>

https://github.com/mozilla/application-services/commit/432aa60735509ca5a860e4dcf993c427cbb44ef3
Authored: 2025-05-22 14:16:47 -0400
Committed: 2025-05-22 19:00:10 +0000

[DISCO-3540] Remove gzip encoding header for merino

Files Modified:

• components/merino/src/curated_recommendations/http.rs

---

ee34bcf1d1059704b0bc596867a2f2006473c184 by Johannes Jörg Schmidt <[e-mail]>

https://github.com/mozilla/application-services/commit/ee34bcf1d1059704b0bc596867a2f2006473c184
Authored: 2025-05-14 11:42:23 +0200
Committed: 2025-05-22 14:16:13 +0000

add logins store api methods for bulk insert and meta insert

The a few new method

fn add_with_record(&self, entry_with_record: LoginEntryWithRecordFields);
fn add_many_with_records(&self, entries_with_records: Vec<LoginEntryWithRecordFields>);
fn add_many(&self, entries: Vec<LoginEntry>);

is intended to be used during migration on desktop.

This renames previously only internally used struct RecordFields to
now exposed LoginMeta for clarity. Also, all structs referencing these
are now called meta instead of record.

Files Modified:

• CHANGELOG.md
• components/logins/src/db.rs
• components/logins/src/encryption.rs
• components/logins/src/login.rs
• components/logins/src/logins.udl
• components/logins/src/store.rs
• components/logins/src/sync/engine.rs
• components/logins/src/sync/merge.rs
• components/logins/src/sync/payload.rs
• components/logins/src/sync/update_plan.rs

---

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=b5453dd8d9fd446a4df2c30bb835031e882d5303

Comment 3

[Update Bot]

Attachment: Bug 1968265 - Update android nightly application-services version bump to acb87bfc59ced0a6fcb23c8d231bd5f690fc76ed

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Try push including the Glean bump: https://treeherder.mozilla.org/jobs?repo=try&revision=98ad4cf5d63f639118c82ee316ed1f32eeba54aa

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4122cf35b568
Update android nightly application-services version bump to acb87bfc59ced0a6fcb23c8d231bd5f690fc76ed r=dmeehan

Comment 6

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 7

[Update Bot]

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4122cf35b568