1968298 - Fix a ruff warning in build/gn_processor.py

Status: RESOLVED DUPLICATE of bug 1978493

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

build/gn_processor.py
343:16: warning Consider merging multiple comparisons: `ext in {".h", ".inc"}`. PLR1714 (ruff)

Link to the code:
https://searchfox.org/mozilla-central/source/build/gn_processor.py#343
To run the linter:

./mach lint -W -l ruff build/gn_processor.py

As the change is trivial, it is just to learn how to contribute to Firefox.

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Khalid AlHaddad]

Attachment: "Bug 1968298 - Fix a ruff warning in gn_processor r=ng".

Comment 2

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:khalid20098, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.

Comment 4

[Tooru Fujisawa [:arai]]

Unfortunately the issue had already been fixed by bug 1978493's patch.
I'm sorry for the landing process not being performed properly.

For the next time, please ask the reviewer for landing the patch once the patch is approved.