Closed
Bug 1978493
Opened 1 year ago
Closed 1 year ago
The chromium/build update added an unnecessary CR_SYSROOT_KEY define, that we should remove in gn_processor.py
Categories
(Core :: WebRTC, defect, P2)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
143 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr128 | --- | unaffected |
| firefox-esr140 | --- | unaffected |
| firefox141 | --- | unaffected |
| firefox142 | --- | wontfix |
| firefox143 | --- | fixed |
People
(Reporter: mjf, Assigned: mjf)
References
(Regression)
Details
(Keywords: regression)
Attachments
(4 external files)
We're removing like things here. We should remove the noise. This will cause updates to both libwebrtc and abseil-cpp moz.build files.
|
||
Comment 1•1 year ago
|
||
Set release status flags based on info from the regressing bug 1974813
status-firefox141:
--- → unaffected
status-firefox142:
--- → affected
status-firefox143:
--- → affected
status-firefox-esr128:
--- → unaffected
status-firefox-esr140:
--- → unaffected
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
|
|
Assignee | |
Comment 3•1 year ago
|
||
|
|
Assignee | |
Comment 4•1 year ago
|
||
|
|
Assignee | |
Comment 5•1 year ago
|
||
Pushed by mfroman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/a86edda8dbf4
https://hg.mozilla.org/integration/autoland/rev/79e40a30cef4
don't include CR_SYSROOT_KEY in moz.build output from gn_processor.py r=ng
https://github.com/mozilla-firefox/firefox/commit/7e8538085e9c
https://hg.mozilla.org/integration/autoland/rev/54e98ccbe513
update generated libwebrtc moz.build files. r=ng
https://github.com/mozilla-firefox/firefox/commit/2cd821caaed0
https://hg.mozilla.org/integration/autoland/rev/989c208ab029
update generated abseil-cpp moz.build files. r=ng
https://github.com/mozilla-firefox/firefox/commit/1c468225e553
https://hg.mozilla.org/integration/autoland/rev/899e8501488c
fix the easy-to-fix lint warnings in gn_processor.py r=ng
Pushed by agoloman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/5d388f16c5d7
https://hg.mozilla.org/integration/autoland/rev/d34f8715261d
Revert (Bug 1978493, Bug 1973648) - for causing build bustages @x_error_trap.h.
|
||
Comment 8•1 year ago
|
||
Backed out for causing build bustages @x_error_trap.h.
Flags: needinfo?(mfroman)
|
|
Assignee | |
Updated•1 year ago
|
Flags: needinfo?(mfroman)
Pushed by mfroman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/279c39bc484e
https://hg.mozilla.org/integration/autoland/rev/c5a194e34993
don't include CR_SYSROOT_KEY in moz.build output from gn_processor.py r=ng
https://github.com/mozilla-firefox/firefox/commit/4463d50e5aac
https://hg.mozilla.org/integration/autoland/rev/601d322009a1
update generated libwebrtc moz.build files. r=ng
https://github.com/mozilla-firefox/firefox/commit/aec1ee18a0df
https://hg.mozilla.org/integration/autoland/rev/6d942683b86b
update generated abseil-cpp moz.build files. r=ng
https://github.com/mozilla-firefox/firefox/commit/d9fea499446b
https://hg.mozilla.org/integration/autoland/rev/702f7071d0ee
fix the easy-to-fix lint warnings in gn_processor.py r=ng
|
||
Comment 10•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c5a194e34993
https://hg.mozilla.org/mozilla-central/rev/601d322009a1
https://hg.mozilla.org/mozilla-central/rev/6d942683b86b
https://hg.mozilla.org/mozilla-central/rev/702f7071d0ee
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 143 Branch
|
||
Updated•1 year ago
|
QA Whiteboard: [qa-triage-done-c144/b143]
You need to log in
before you can comment on or make changes to this bug.
Description
•