1968626 - The Message Security pop-up hides part of the Import Public Key dialog

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Geoff Lankow (:darktrojan)]

Attachment: image.png

If you click on the OpenPGP button in the message header, then the Import… button in the message security pop-up, the pop-up remains open while the public key importing dialog is open (because it's modal, and the main window can't do anything until it is closed). But this (in some circumstances) hides parts of the importing dialog, including the action buttons, which is confusing and makes it difficult to use.

Ways we could fix this:

• hide the pop-up before opening the dialog
• make the dialog much smaller, removing all of the empty space (still not a great, IMO)
• incorporate the key import UI into the message security pop-up
• make the dialog part of the main window (i.e. an HTML <dialog>)

Comment 1

[Magnus Melin [:mkmelin]]

Hiding before opening the dialog is an easy short term fix.
The whole import UI needs a serious rewrite though.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: WIP: Bug 1968626 - The Message Security pop-up hides part of the Import Public Key dialog

Tests to adjust: https://searchfox.org/comm-central/search?q=messageSecurityPanel&path=

Comment 3

[Kai Engert [:KaiE:]]

I think the popup must be closed. And that used to happen in the past. Usually, whatever you clicked while that popup was showing, it was closing automatically. Why is it no longer being closed automatically?

Comment 4

[Kai Engert [:KaiE:]]

Has something changed how the popup windows behave, or how windows behave in general?

I think in the past things just worked automatically. We got the button click, we executed the code, and the popup disappeared automatically. Why does that no longer happen automatically?

Magnus' patch doesn't work correctly in the "view signature key" scenario. As soon as we call hidePopup(), that scope seems to go away immediately, and viewSignatureKey() no longer works. While it's still possible to call viewSignatureKey() (code is reached), that code refers to a global function in the scope (gSigKeyId), and that has already been released, it's null.

So apparently we need a more sophisticated logic. We need to pass the popup window as a paramater to those functions. Once arriving there, the function needs to make a copy of all variables from self's scope that it needs. Then it can use the given parameter to call hidePopup(). Then it can call the intended action, using the saved information.

Comment 5

[Kai Engert [:KaiE:]]

I'm attaching a modified patch that works for me locally, and doesn't require changes to tests.

Comment 6

[Kai Engert [:KaiE:]]

Attachment: Bug 1968626 - Close security info popup when clicking a button inside it. r=darktrojan

Comment 7

[Kai Engert [:KaiE:]]

Shouldn't be necessary to leave-open, the additional patch is obsolete, will be abandoned.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/503c7d0670c4
Close security info popup when clicking a button inside it. r=darktrojan

Comment 9

[Brendan Abolivier [:babolivier]]

Ah fair enough, my bad.