1968870 - Pass referrer to HostLoadImportedModule in dynamic import

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This is a follow-up from https://phabricator.services.mozilla.com/D214569
According to the spec, https://tc39.es/ecma262/#sec-evaluate-import-call
We need to get the referrer information and pass it to HostLoadImportedModule.

Comment 1

[Jon Coppeard (:jonco)]

For dynamic import we have the possibility that the referrer is a classic script. Currently the referrer is passed as a module object. There are a couple of ways we could make this work (pass either using a Value or always pass a script). Currently the module loader doesn't use referrer much, possibly because it's not always available.

The aim of all of this should be to have a single HostLoadImportedModule function in the engine that is used in all places. Currently we call the module load hook twice outside of this function.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1968870 - Part 1: Pass referrer as script rather than object r?allstarschh

Previously we passed the module object for modules and nullptr for other cases.
This patch makes it so we pass the script for both module and classic script
referrers, and nullptr for the realm case.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1968870 - Part 2: Don't pass referencingPrivate to FinishLoadingImportedModule r?allstarschh

This already takes the referrer script. We can use the referrer script to keep
its private value alive in DynamicImportContextObject which is much simpler.

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1968870 - Part 3: Remove use of referencing private in shell module loader r?allstarschh

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1968870 - Part 4: Remove use of referencing private in browser module loader r?allstarschh

Comment 6

[Jon Coppeard (:jonco)]

Attachment: Bug 1968870 - Part 5: Stop passing referencing private to module load hook r?allstarschh

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/84fafeaa92cd
https://hg.mozilla.org/integration/autoland/rev/373a0f470ec4
Part 1: Pass referrer as script rather than object r=allstarschh
https://github.com/mozilla-firefox/firefox/commit/98df766730f6
https://hg.mozilla.org/integration/autoland/rev/46cf58f2d993
Part 2: Don't pass referencingPrivate to FinishLoadingImportedModule r=allstarschh
https://github.com/mozilla-firefox/firefox/commit/c316912eb02d
https://hg.mozilla.org/integration/autoland/rev/1c8a5ff6db56
Part 3: Remove use of referencing private in shell module loader r=allstarschh
https://github.com/mozilla-firefox/firefox/commit/bc5f40513635
https://hg.mozilla.org/integration/autoland/rev/4a453f447cba
Part 4: Remove use of referencing private in browser module loader r=allstarschh
https://github.com/mozilla-firefox/firefox/commit/d7c24993b7d7
https://hg.mozilla.org/integration/autoland/rev/713598f2054c
Part 5: Stop passing referencing private to module load hook r=allstarschh

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/373a0f470ec4
https://hg.mozilla.org/mozilla-central/rev/46cf58f2d993
https://hg.mozilla.org/mozilla-central/rev/1c8a5ff6db56
https://hg.mozilla.org/mozilla-central/rev/4a453f447cba
https://hg.mozilla.org/mozilla-central/rev/713598f2054c