1820594 - Update module import hooks to reflect changes in spec

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Yulia Startsev [:yulia] OOO until July 2026]

Recently a refactor to html and ecma262 landed which refactors and simplifies the host hooks. Presentation is here: https://docs.google.com/presentation/d/1RVUE-MENQT8dj2wxvMLMDxg_VoMOwiwNQQged39QIEU/edit#slide=id.g1489ab97056_2_334

write up: https://github.com/nicolo-ribaudo/modules-import-hooks-refactor
Changes to HTML: https://github.com/whatwg/html/pull/8253
Changes to ecma262: https://nicolo-ribaudo.github.io/modules-import-hooks-refactor/

We will need to do this before the larger components of Modules Harmony lands, this includes in particular import reflection and module blocks, as both are already quite mature.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 1: Add ModuleStatus::New.

According to Additional Fields of Cyclic Module Records.
https://tc39.es/ecma262/#cyclic-module-record

Add a ModuleStatus::New to map to the [[Status]]::New

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 2: Implement GraphLoadingStateRecord.

See https://tc39.es/ecma262/#graphloadingstate-record

From the specification, the operation uses the PromiseCapability record
to notify when it is resolved or rejected. However, to accommodate our
synchronous loader, mozJSModuleLoader, I have modified the implementation to
use function callbacks instead. This change ensures compatibility with our
existing synchronous loading mechanism.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 3: Implement LoadedModules in ModuleObject.

Implement [[LoadedModules]] in https://tc39.es/ecma262/#table-cyclic-module-fields

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 5: Update Module Hook.

Replace resolve hook and dynamic import hook with load hook.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 4: Implement GetImportedModule.

Implement https://tc39.es/ecma262/#sec-GetImportedModule
and update the callers accordingly.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 8: Update js::FinishDynamicModuleImport.

Originally FinishDynamicModuleImport would resolve the module object,
now we resolve the module object in HostLoadImportedModule, and pass the
module object to FinishDynamicModuleImport.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 6: Implement InnerModuleLoading.

Implement InnerModuleLoading in https://tc39.es/ecma262/#sec-InnerModuleLoading

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 9: Implement FinishLoadingImportedModule, ContinueModuleLoading.

Implement https://tc39.es/ecma262/#sec-FinishLoadingImportedModule
and https://tc39.es/ecma262/#sec-ContinueModuleLoading

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 10: Implement ImportAttributes in InnerModuleLoading.

Implement Import-Attributes change from https://tc39.es/proposal-import-attributes/#sec-InnerModuleLoading

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 11: Implement LoadRequestedModules.

Implement https://tc39.es/ecma262/#sec-LoadRequestedModules

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 11: Call ModuleLoadRequestedModule for static import in ModuleLoaderBase and shell.

This makes the call to ModuleLoadRequest::InstantiateModuleGraph() from
ModuleLoerBase and ModuleLink() in js shell will call
ModuleLoadRequestedModules() first, and call ModuleLink() in the
resolved callback.

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 25: Call FinishLoadingImportedModule for dynamic import.

From the specification, ContinueDynamicImport is done inside the engine.
https://tc39.es/ecma262/#sec-ContinueDynamicImport

However, our implementation for EvaluateModuleInContext() has bytecode
encoding related stuff, so for now I implement the ContinueDynamicImport
in the host layer.

Also, the updated spec has a slightly different error handling behavior when
module.Link() fails. I list them below:

Before HTML PR 8253 [https://github.com/whatwg/html/pull/8253]

fetch the descendants of and link a module script
https://web.archive.org/web/20221130023614/https://html.spec.whatwg.org/#fetch-the-descendants-of-and-link-a-module-script

onFetchDescendantsComplete
Step 3.2. Perform record.Link().
If this throws an exception, set result's error to rethrow to that exception.

HostImportModuleDynamically
https://web.archive.org/web/20221130023614/https://html.spec.whatwg.org/#hostimportmoduledynamically(referencingscriptormodule,-modulerequest,-promisecapability)
Step 6.3 Otherwise, set promise to the result of running a module script given result and true.

run a module script
https://web.archive.org/web/20221130023614/https://html.spec.whatwg.org/#run-a-module-script
Step 5. If script's error to rethrow is not null, then set evaluationPromise to a promise rejected with script's error to rethrow.

---

After ECMA262 PR 2905 [https://github.com/tc39/ecma262/pull/2905]
ContinueDynamicImport
Step 6.a Let link be Completion(module.Link()).
Step 6.b If link is an abrupt completion, then
Step 6.b.i. Perform ! Call(promiseCapability.[[Reject]], undefined, « link.[[Value]] »).
Step 6.b.ii. Return unused.

In short, the old behavior would catch the exception thrown during
module.Link(), and set the module script's error to rethrow to the
exception. Later in Evaluate(), if the module script's error to rethrow
is not null, reject the evaluation promise with the error to rethrow.
And the new behavior is simply reject the evaluation promise with the
exception thrown during module.Link().

To address this change, I add another
InstantiateDynamicImportModuleGraph() for the different error handling,
and slightly update ModuleLoaderBase::FinishDynamicImport to check if
any exception has been thrown already.

Comment 14

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 13: Implement HostLoadImportedModule in ModuleLoaderBase.cpp and shell's ModuleLoader.cpp.

Comment 15

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 26: Remove FindFirstParseError and check for parse error.

The changes in whatwg/html#8253
remove the "Find the first parse error" part. As a result, checking for
parse errors is now done in InstantiateModuleGraph() and
HostLoadImportedModule().

In our implementation, if a ModuleScript has a parse error, it
originally called LoadFinished(), which in turn called
onModuleLoadComplete. However, for WorkerModuleLoader and
WorkletModuleLoader, they called InstantiateModuleGraph(), which then
called HostLoadImportedModule(). This sequence couldn't find the module
script with the parse error, leading to an assertion failure.

To fix this issue, the call to ModuleErrored() has been moved to occur
once the ModuleScript has been inserted into mFetchModules.

Comment 16

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 32: Remove js/src/jit-test/tests/modules/bug-1287410.js.

Now the modules will be stored in LoadedModules() of the module object,
replace a already instantiated module with a new one won't trigger the
problem.

Comment 17

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 13: Resume waiting requests after fetching dependencies.

Comment 18

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 14: Remove VisitedURLSet.

Comment 19

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 15: Remove HostResolveImportedModule and HostImportModuleDynamically

Comment 20

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 18: Add mReferrerObj, mModuleRequestObj, mReferencingPrivate, mStatePrivate in ModuleLoadRequest

Comment 21

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 17: Add OnFetchSucceeded

Comment 22

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 19: Introduce ModuleScriptRequest struct and store it in mFetchedModules.

Comment 23

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 20: update mFetchedModules for inline modules.

Comment 24

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 21: Implement HostLoadImportedModule and FinishLoadingImportedModule in ModuleLoaderBase.

Comment 25

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 22: Add GetGraphLoadingStateHostDefined.

Comment 26

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 23: Add State::Loaded.

Comment 27

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 24: Update module graph's states when loaded.

• UpdateToDependenciesLoaded
• Check parent->IsTopLevel in ChildLoadComplete

Comment 28

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 23: Error handling when module fetching failed.

Comment 29

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 28: Add JS::GraphLoadingStateContains.

Comment 30

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 30: Prevent cyclic modules in InitDebuggerDataForModuleGraph

Comment 31

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 28: DOM, Worker, Worklet ScriptLoader, mozJSModuleLoader update

Comment 32

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 31: Test the child requests accross multiple module graphs.

Comment 33

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 29: add mInitImports in ModuleLoadRequest

Comment 34

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 29: Remove ModuleLoader::ResolveImportedModule and ModuleLoader::ImportModuleDynamically in JS Shell

Comment 35

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 30: Update JS Shell implementation for HostLoadImportedModule.

Comment 36

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 33: Update testing/web-platform/tests/html/semantics/scripting-1/the-script-element/module/choice-of-error-1.html.

Originally each module graph will get different ParseError due to
FindFirstParseError algorithm,
now once a parse error is found, the error will be set to the error to rethrow
on the root module, hence both module graph should get the same error.

Comment 37

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 34: Update error-type-1.html

Comment 38

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 33: Add mCanceledWhileFetching flag to reset mReferreObj and mModuleRequestObj

Comment 39

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 7: Remove JS::FinishDynamicModuleImport.

Comment 40

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 12: Implement ContinueDynamicImport.

Comment 41

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 22: Throw TypeError if the module type is unsupported.

Comment 42

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 39: WIP - Add APIs for ModuleEvaluateHook

Comment 43

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 40: WIP: Implement HostEvaluateHook in ModuleLoaderBase

Comment 44

[Jon Coppeard (:jonco)]

Attachment: WIP: Bug 1820594 - Part 41: Remove unused version of LoadRequestedModules

Comment 45

[Jon Coppeard (:jonco)]

Attachment: WIP: Bug 1820594 - Part 42: Do debugger initialization as part of module linking

I haven't tested this particularly but this should work.

Comment 46

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 16: Call LoadRequestedModules in StartFetchingModuleDependencies.

Comment 47

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 34: Update wpt ini for dynamic import.

Comment 48

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - WIP: Do debugger initialization during Module Linking.

Comment 49

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, arai
I'd like to ask for your suggestion.
Currently I have one xpcshell failure in test_import_global_current.js, it fails in testSyncImportWhileAsyncImportTLA

The try failure is here

Originally (in current m-c), the window.import will fetch the TLA script (es6module_top_level_await.js), then it will be moved to loaded list,
And ScriptLoader will process the loaded request

Now with the patches in this bug here. Part 16 will call LoadRequestedModules, and the module will be loaded in Part 24, notice that the module is loaded when the promise from LoadRequestedModules is resolved. At that time ScriptLoader::OnStreamComplete has returned.
When the module is loaded, it will process the loaded requests asynchronously.
But before the module is processed, the ChromeUtils.importESModule is executed, then the module evaluation from ChromeUtils.importESModule will trigger the assertion

So my question is the test testSyncImportWhileAsyncImportTLA still valid after this bug? As window.import now will take longer to do the actual module evaluation, and what and how should the ChromeUtils.importESModule behave while the importing TLA is still executing?

Thanks

Comment 50

[Tooru Fujisawa [:arai]]

At least, hitting an assertion failure sounds like there's an issue in the implementation side, not only in the testcase alone.

Then, I think this was actually a pre-existing issue, where the testcase wasn't hitting the problematic path.

We should expect the evaluation promise to be pending for { global: "current" } option, given that the modules it's seeing can be handled by the regular module loader with supports TLA with pending promises.

Thus, we should have another branch around the following code to handle the case where evaluationPromise is pending, and throw an error about "imported module has TLA and it's still getting executed by other module loader", or something says "modules with TLA can be imported with importESModule only after the module is fully evaluated".
We should also assert that the pending case happens only with { global: "current" } option (otherwise the promise shouldn't be pending at that point).

https://searchfox.org/mozilla-central/rev/a67f2f0854c99bf35cf7e41c0610db7b9bf2c8e2/js/loader/ModuleLoaderBase.cpp#1480-1481

if (!JS::ThrowOnModuleEvaluationFailure(aCx, evaluationPromise,
                                        errorBehaviour)) {

Feel free to disable the testcase for now.
I can look into it later.

Comment 51

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 19: Refactor CreateStaticImport.

Store LoadContextBase and RootedModule information into LoadedScript/ModuleScript.

Comment 52

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 20: Update module script's referrer policy.

• Move UpdateReferrerPolicy from ScriptLoadRequest to ModuleLoadRequest,
  as this can only happend for a module load.

• Add UpdateReferrerPolicy method to ModuleScript.
  Introduces a new UpdateReferrerPolicy method for ModuleScript,
  allowing the referrer policy to be updated based on the associated
  ModuleLoadRequest.

Comment 53

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 24: Add ModuleErroredRunnable to dispatch ModuleErrored.

When there's a ParseError, the error should be dispatched asynchronously.
However, workers can't handle the micro task, therefore we still call
ModuleErrored synchronously.

WPT test: /html/semantics/scripting-1/the-script-element/module/inline-async-inserted-execorder.html

Comment 54

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 27: Remove redundant module graph data structures from host layer.

Since the module graph is now traversed within the JS engine itself, the
related data structures in the host layer are no longer necessary.

Comment 55

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 35: Disable testSyncImportWhileAsyncImportTLA.

Comment 56

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

try : https://treeherder.mozilla.org/jobs?repo=try&revision=686edbbfe62bb67d8cd4cf75274d50e330bb329e

Comment 57

[Phabricator Automation]

Comment on attachment 9438862 [details]
Bug 1820594 - Part 33: Update testing/web-platform/tests/html/semantics/scripting-1/the-script-element/module/choice-of-error-1.html.

Revision D229652 was moved to bug 1974658. Setting attachment 9438862 [details] to obsolete.

Comment 58

[Phabricator Automation]

Comment on attachment 9439079 [details]
Bug 1820594 - Part 34: Update error-type-1.html

Revision D229651 was moved to bug 1974658. Setting attachment 9439079 [details] to obsolete.

Comment 59

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 33: Update choice-of-error-1.html.ini and error-type-1.html.ini failed as expected.

Comment 60

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 16-1 : Use sync version of LoadRequestedModules for chrome pages.

In mochitest-browser tests, it's possible for the about:neterror page to
load. This triggers aboutNetError.html, which in turn loads aboutNetError.mjs.

Occasionally, the load promise from
LoadRequestedModules(aboutNetError.mjs) is never resolved because the
PromiseJobRunnable is not executed if the global is in the process of
shutting down.

To avoid this issue, we now use the synchronous version of
LoadRequestedModules when loading chrome resources.

Comment 61

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1820594 - Part 36: Add CancelFetchingModules.

In mochitest-browser tests, it's possible for the about:neterror page to
load. This triggers aboutNetError.html, which in turn loads
aboutNetError.mjs, eventually importing pkijs.js. The pkijs.js module is
compiled off-thread.

However, when the test framework proceeds to the next test, the
associated document may be detached before the off-thread compilation of
pkijs.js completes. If this happens while TaskController is shutting
down, the compilation task may never finish.

Currently, ScriptLoader only tracks top-level off-thread compilation
requests, not submodules involved in those tasks. To address this, we
now call CancelFetchingModules when ScriptLoader cancels ongoing
requests, ensuring submodule fetches are also properly aborted.

Comment 62

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bfd2615ef195
https://hg.mozilla.org/integration/autoland/rev/c4deab997a08
Part 1: Add ModuleStatus::New. r=jonco
https://github.com/mozilla-firefox/firefox/commit/05a2b76d9c08
https://hg.mozilla.org/integration/autoland/rev/5db2670b50c6
Part 2: Implement GraphLoadingStateRecord. r=jonco
https://github.com/mozilla-firefox/firefox/commit/f639c7eb9620
https://hg.mozilla.org/integration/autoland/rev/b9e0a5069871
Part 3: Implement LoadedModules in ModuleObject. r=jonco
https://github.com/mozilla-firefox/firefox/commit/19507524a2e6
https://hg.mozilla.org/integration/autoland/rev/045516a59e28
Part 4: Implement GetImportedModule. r=jonco
https://github.com/mozilla-firefox/firefox/commit/4f00fb82af4a
https://hg.mozilla.org/integration/autoland/rev/4b587d61e767
Part 5: Update Module Hook. r=jonco
https://github.com/mozilla-firefox/firefox/commit/ef4d03deaf29
https://hg.mozilla.org/integration/autoland/rev/bc7618ad2c34
Part 6: Implement InnerModuleLoading. r=jonco
https://github.com/mozilla-firefox/firefox/commit/1e6d8581b93b
https://hg.mozilla.org/integration/autoland/rev/0292b31b5fbd
Part 7: Remove JS::FinishDynamicModuleImport. r=jonco
https://github.com/mozilla-firefox/firefox/commit/f5546f06d267
https://hg.mozilla.org/integration/autoland/rev/b000b34a212f
Part 8: Update js::FinishDynamicModuleImport. r=jonco
https://github.com/mozilla-firefox/firefox/commit/85bcdccef34b
https://hg.mozilla.org/integration/autoland/rev/deb9edd6a57f
Part 9: Implement FinishLoadingImportedModule, ContinueModuleLoading. r=jonco
https://github.com/mozilla-firefox/firefox/commit/3115d8a191c5
https://hg.mozilla.org/integration/autoland/rev/1a13659c86e8
Part 10: Implement ImportAttributes in InnerModuleLoading. r=jonco
https://github.com/mozilla-firefox/firefox/commit/0049bf82d126
https://hg.mozilla.org/integration/autoland/rev/e9e1b6fc8bf2
Part 11: Implement LoadRequestedModules. r=jonco
https://github.com/mozilla-firefox/firefox/commit/b487d8ffec7f
https://hg.mozilla.org/integration/autoland/rev/46f44a3082c5
Part 12: Implement ContinueDynamicImport. r=jonco
https://github.com/mozilla-firefox/firefox/commit/a5edee9705c6
https://hg.mozilla.org/integration/autoland/rev/87e34685a86f
Part 13: Resume waiting requests after fetching dependencies. r=jonco
https://github.com/mozilla-firefox/firefox/commit/09f1ea1a1a88
https://hg.mozilla.org/integration/autoland/rev/6ff927b808a4
Part 14: Remove VisitedURLSet. r=jonco
https://github.com/mozilla-firefox/firefox/commit/8c45c3380e4b
https://hg.mozilla.org/integration/autoland/rev/a225c8cf8cd5
Part 15: Remove HostResolveImportedModule and HostImportModuleDynamically r=jonco
https://github.com/mozilla-firefox/firefox/commit/cf9a4a886df3
https://hg.mozilla.org/integration/autoland/rev/f02c6f496cad
Part 16: Call LoadRequestedModules in StartFetchingModuleDependencies. r=jonco
https://github.com/mozilla-firefox/firefox/commit/a75c3d1989f8
https://hg.mozilla.org/integration/autoland/rev/cd1f242dade1
Part 16-1 : Use sync version of LoadRequestedModules for chrome pages. r=jonco
https://github.com/mozilla-firefox/firefox/commit/4b60b4037a55
https://hg.mozilla.org/integration/autoland/rev/30410e042280
Part 17: Add OnFetchSucceeded r=jonco
https://github.com/mozilla-firefox/firefox/commit/96b553c522fc
https://hg.mozilla.org/integration/autoland/rev/c479c528c2fd
Part 18: Add mReferrerObj, mModuleRequestObj, mReferencingPrivate, mStatePrivate in ModuleLoadRequest r=jonco
https://github.com/mozilla-firefox/firefox/commit/e7cc5dcf27f1
https://hg.mozilla.org/integration/autoland/rev/425e6e784b4e
Part 19: Refactor CreateStaticImport. r=jonco
https://github.com/mozilla-firefox/firefox/commit/e92cdaa12999
https://hg.mozilla.org/integration/autoland/rev/f82327c72c57
Part 20: Update module script's referrer policy. r=jonco
https://github.com/mozilla-firefox/firefox/commit/2c2abeb8a3e7
https://hg.mozilla.org/integration/autoland/rev/37aa0de87918
Part 21: Implement HostLoadImportedModule and FinishLoadingImportedModule in ModuleLoaderBase. r=jonco
https://github.com/mozilla-firefox/firefox/commit/f793f2b08688
https://hg.mozilla.org/integration/autoland/rev/54251d5b6cd5
Part 22: Throw TypeError if the module type is unsupported. r=jonco
https://github.com/mozilla-firefox/firefox/commit/8054f6d6b318
https://hg.mozilla.org/integration/autoland/rev/adb7e8ccd69a
Part 23: Error handling when module fetching failed. r=jonco
https://github.com/mozilla-firefox/firefox/commit/aa0e96e6c157
https://hg.mozilla.org/integration/autoland/rev/7d143e3db297
Part 24: Add ModuleErroredRunnable to dispatch ModuleErrored. r=jonco
https://github.com/mozilla-firefox/firefox/commit/9037595d2781
https://hg.mozilla.org/integration/autoland/rev/e52ac6aa02c1
Part 25: Call FinishLoadingImportedModule for dynamic import. r=jonco
https://github.com/mozilla-firefox/firefox/commit/665970f84791
https://hg.mozilla.org/integration/autoland/rev/bc27f738ab53
Part 26: Remove FindFirstParseError and check for parse error. r=jonco
https://github.com/mozilla-firefox/firefox/commit/81673cfb4e6c
https://hg.mozilla.org/integration/autoland/rev/6406483d53a7
Part 27: Remove redundant module graph data structures from host layer. r=jonco
https://github.com/mozilla-firefox/firefox/commit/86aea74da6d8
https://hg.mozilla.org/integration/autoland/rev/f34df5d6d250
Part 28: DOM, Worker, Worklet ScriptLoader, mozJSModuleLoader update r=jonco
https://github.com/mozilla-firefox/firefox/commit/aa686310fc36
https://hg.mozilla.org/integration/autoland/rev/078a3cdf5cd7
Part 29: Remove ModuleLoader::ResolveImportedModule and ModuleLoader::ImportModuleDynamically in JS Shell r=jonco
https://github.com/mozilla-firefox/firefox/commit/5a2f281ba707
https://hg.mozilla.org/integration/autoland/rev/f48c98c10cef
Part 30: Update JS Shell implementation for HostLoadImportedModule. r=jonco
https://github.com/mozilla-firefox/firefox/commit/fc403c5ea97b
https://hg.mozilla.org/integration/autoland/rev/ec26cd0ac7bd
Part 31: Test the child requests accross multiple module graphs. r=jonco
https://github.com/mozilla-firefox/firefox/commit/6a47bd9a7c2a
https://hg.mozilla.org/integration/autoland/rev/bcb51f401536
Part 32: Remove js/src/jit-test/tests/modules/bug-1287410.js. r=jonco
https://github.com/mozilla-firefox/firefox/commit/696d4051b251
https://hg.mozilla.org/integration/autoland/rev/2bac600a9e4a
Part 33: Update choice-of-error-1.html.ini and error-type-1.html.ini failed as expected. r=jonco
https://github.com/mozilla-firefox/firefox/commit/6dc30859a292
https://hg.mozilla.org/integration/autoland/rev/3f9cda7af2bc
Part 34: Update wpt ini for dynamic import. r=jonco
https://github.com/mozilla-firefox/firefox/commit/bd7ac6c6dac3
https://hg.mozilla.org/integration/autoland/rev/23c1514d4c46
Part 35: Disable testSyncImportWhileAsyncImportTLA. r=arai
https://github.com/mozilla-firefox/firefox/commit/bb9106dfec70
https://hg.mozilla.org/integration/autoland/rev/2320382eddda
Part 36: Add CancelFetchingModules. r=jonco

Comment 63

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f46ece6f70e1
https://hg.mozilla.org/integration/autoland/rev/48134d64e64b
Revert "Bug 1820594 - Part 36: Add CancelFetchingModules. r=jonco" for causing failures at mochitest.toml.

Comment 64

[Atila Butkovits]

Backed out for causing failures at mochitest.toml.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/48134d64e64b943367db3910dac7bebec3c06d28

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=X3xzczyNSnG37QvJ798DAA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2320382eddda48ef1cf314b12987d967293d2b2f

Failure log: https://treeherder.mozilla.org/logviewer?job_id=518834855&repo=autoland&lineNumber=4976

Comment 65

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

I'll check the leak, thanks.

Comment 66

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b7653ddc0605
https://hg.mozilla.org/integration/autoland/rev/0edfd9c6884d
Part 1: Add ModuleStatus::New. r=jonco
https://github.com/mozilla-firefox/firefox/commit/5794f2e2ec7d
https://hg.mozilla.org/integration/autoland/rev/b6d75f4f4756
Part 2: Implement GraphLoadingStateRecord. r=jonco
https://github.com/mozilla-firefox/firefox/commit/e18a469866a3
https://hg.mozilla.org/integration/autoland/rev/0ae144aca175
Part 3: Implement LoadedModules in ModuleObject. r=jonco
https://github.com/mozilla-firefox/firefox/commit/97f18986dbe3
https://hg.mozilla.org/integration/autoland/rev/96ab5aa70275
Part 4: Implement GetImportedModule. r=jonco
https://github.com/mozilla-firefox/firefox/commit/a9c5e5494278
https://hg.mozilla.org/integration/autoland/rev/a8a18d8f7237
Part 5: Update Module Hook. r=jonco
https://github.com/mozilla-firefox/firefox/commit/f75396a2687a
https://hg.mozilla.org/integration/autoland/rev/d07c809e1fd7
Part 6: Implement InnerModuleLoading. r=jonco
https://github.com/mozilla-firefox/firefox/commit/ddf8de3cc166
https://hg.mozilla.org/integration/autoland/rev/528371e474bb
Part 7: Remove JS::FinishDynamicModuleImport. r=jonco
https://github.com/mozilla-firefox/firefox/commit/4c3086d007ac
https://hg.mozilla.org/integration/autoland/rev/1d7c093083ea
Part 8: Update js::FinishDynamicModuleImport. r=jonco
https://github.com/mozilla-firefox/firefox/commit/76fbf186c099
https://hg.mozilla.org/integration/autoland/rev/a35abbf73367
Part 9: Implement FinishLoadingImportedModule, ContinueModuleLoading. r=jonco
https://github.com/mozilla-firefox/firefox/commit/13fb577be23d
https://hg.mozilla.org/integration/autoland/rev/69f593198e24
Part 10: Implement ImportAttributes in InnerModuleLoading. r=jonco
https://github.com/mozilla-firefox/firefox/commit/29eea71f201c
https://hg.mozilla.org/integration/autoland/rev/bd54f46cdae0
Part 11: Implement LoadRequestedModules. r=jonco
https://github.com/mozilla-firefox/firefox/commit/2662812a51fd
https://hg.mozilla.org/integration/autoland/rev/440c2a2605b3
Part 12: Implement ContinueDynamicImport. r=jonco
https://github.com/mozilla-firefox/firefox/commit/e10ced86e911
https://hg.mozilla.org/integration/autoland/rev/03007620a79e
Part 13: Resume waiting requests after fetching dependencies. r=jonco
https://github.com/mozilla-firefox/firefox/commit/00a8ab1fcee1
https://hg.mozilla.org/integration/autoland/rev/c5eabc03ec00
Part 14: Remove VisitedURLSet. r=jonco
https://github.com/mozilla-firefox/firefox/commit/a2b683969197
https://hg.mozilla.org/integration/autoland/rev/46fc20c776f5
Part 15: Remove HostResolveImportedModule and HostImportModuleDynamically r=jonco
https://github.com/mozilla-firefox/firefox/commit/5c786aae1ffc
https://hg.mozilla.org/integration/autoland/rev/04606db11850
Part 16: Call LoadRequestedModules in StartFetchingModuleDependencies. r=jonco
https://github.com/mozilla-firefox/firefox/commit/a48f69ed7934
https://hg.mozilla.org/integration/autoland/rev/8d8d07e5b63c
Part 16-1 : Use sync version of LoadRequestedModules for chrome pages. r=jonco
https://github.com/mozilla-firefox/firefox/commit/2a6b58d511b4
https://hg.mozilla.org/integration/autoland/rev/e4cb2d8bc88f
Part 17: Add OnFetchSucceeded r=jonco
https://github.com/mozilla-firefox/firefox/commit/2f395ffaf723
https://hg.mozilla.org/integration/autoland/rev/cfff4af812f1
Part 18: Add mReferrerObj, mModuleRequestObj, mReferencingPrivate, mStatePrivate in ModuleLoadRequest r=jonco
https://github.com/mozilla-firefox/firefox/commit/745139e2c815
https://hg.mozilla.org/integration/autoland/rev/2b33077bbe0b
Part 19: Refactor CreateStaticImport. r=jonco
https://github.com/mozilla-firefox/firefox/commit/cfaa6e7c060a
https://hg.mozilla.org/integration/autoland/rev/99cfceaf276b
Part 20: Update module script's referrer policy. r=jonco
https://github.com/mozilla-firefox/firefox/commit/14ef8f5fdbd2
https://hg.mozilla.org/integration/autoland/rev/6d0c7a363043
Part 21: Implement HostLoadImportedModule and FinishLoadingImportedModule in ModuleLoaderBase. r=jonco
https://github.com/mozilla-firefox/firefox/commit/b4418fa96d3a
https://hg.mozilla.org/integration/autoland/rev/6ef880c3361e
Part 22: Throw TypeError if the module type is unsupported. r=jonco
https://github.com/mozilla-firefox/firefox/commit/33d4e771ca4f
https://hg.mozilla.org/integration/autoland/rev/8ce9c39a01cc
Part 23: Error handling when module fetching failed. r=jonco
https://github.com/mozilla-firefox/firefox/commit/2d3841c2a04f
https://hg.mozilla.org/integration/autoland/rev/46f3fb297eee
Part 24: Add ModuleErroredRunnable to dispatch ModuleErrored. r=jonco
https://github.com/mozilla-firefox/firefox/commit/2464b45fe0e7
https://hg.mozilla.org/integration/autoland/rev/70e571a4d115
Part 25: Call FinishLoadingImportedModule for dynamic import. r=jonco
https://github.com/mozilla-firefox/firefox/commit/4f92fa4f2d6f
https://hg.mozilla.org/integration/autoland/rev/b21b6ee4cd76
Part 26: Remove FindFirstParseError and check for parse error. r=jonco
https://github.com/mozilla-firefox/firefox/commit/264c8307be5e
https://hg.mozilla.org/integration/autoland/rev/e505acd05133
Part 27: Remove redundant module graph data structures from host layer. r=jonco
https://github.com/mozilla-firefox/firefox/commit/a45a4b166239
https://hg.mozilla.org/integration/autoland/rev/609d8edb3283
Part 28: DOM, Worker, Worklet ScriptLoader, mozJSModuleLoader update r=jonco
https://github.com/mozilla-firefox/firefox/commit/101f455ecf07
https://hg.mozilla.org/integration/autoland/rev/028810114451
Part 29: Remove ModuleLoader::ResolveImportedModule and ModuleLoader::ImportModuleDynamically in JS Shell r=jonco
https://github.com/mozilla-firefox/firefox/commit/9b69569913ab
https://hg.mozilla.org/integration/autoland/rev/3119dda70eb8
Part 30: Update JS Shell implementation for HostLoadImportedModule. r=jonco
https://github.com/mozilla-firefox/firefox/commit/16dd3441e9b9
https://hg.mozilla.org/integration/autoland/rev/3f0c9544000e
Part 31: Test the child requests accross multiple module graphs. r=jonco
https://github.com/mozilla-firefox/firefox/commit/27682875fd7c
https://hg.mozilla.org/integration/autoland/rev/f2b1698faa37
Part 32: Remove js/src/jit-test/tests/modules/bug-1287410.js. r=jonco
https://github.com/mozilla-firefox/firefox/commit/6232bc1f6b39
https://hg.mozilla.org/integration/autoland/rev/277e23f39103
Part 33: Update choice-of-error-1.html.ini and error-type-1.html.ini failed as expected. r=jonco
https://github.com/mozilla-firefox/firefox/commit/e4784b66b5ab
https://hg.mozilla.org/integration/autoland/rev/bbd0092e97a3
Part 34: Update wpt ini for dynamic import. r=jonco
https://github.com/mozilla-firefox/firefox/commit/3a92e676705b
https://hg.mozilla.org/integration/autoland/rev/e2972b033db7
Part 35: Disable testSyncImportWhileAsyncImportTLA. r=arai
https://github.com/mozilla-firefox/firefox/commit/a61af56c37dd
https://hg.mozilla.org/integration/autoland/rev/90cbfb6edeef
Part 36: Add CancelFetchingModules. r=jonco

Comment 67

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/0edfd9c6884d
https://hg.mozilla.org/mozilla-central/rev/b6d75f4f4756
https://hg.mozilla.org/mozilla-central/rev/0ae144aca175
https://hg.mozilla.org/mozilla-central/rev/96ab5aa70275
https://hg.mozilla.org/mozilla-central/rev/a8a18d8f7237
https://hg.mozilla.org/mozilla-central/rev/d07c809e1fd7
https://hg.mozilla.org/mozilla-central/rev/528371e474bb
https://hg.mozilla.org/mozilla-central/rev/1d7c093083ea
https://hg.mozilla.org/mozilla-central/rev/a35abbf73367
https://hg.mozilla.org/mozilla-central/rev/69f593198e24
https://hg.mozilla.org/mozilla-central/rev/bd54f46cdae0
https://hg.mozilla.org/mozilla-central/rev/440c2a2605b3
https://hg.mozilla.org/mozilla-central/rev/03007620a79e
https://hg.mozilla.org/mozilla-central/rev/c5eabc03ec00
https://hg.mozilla.org/mozilla-central/rev/46fc20c776f5
https://hg.mozilla.org/mozilla-central/rev/04606db11850
https://hg.mozilla.org/mozilla-central/rev/8d8d07e5b63c
https://hg.mozilla.org/mozilla-central/rev/e4cb2d8bc88f
https://hg.mozilla.org/mozilla-central/rev/cfff4af812f1
https://hg.mozilla.org/mozilla-central/rev/2b33077bbe0b
https://hg.mozilla.org/mozilla-central/rev/99cfceaf276b
https://hg.mozilla.org/mozilla-central/rev/6d0c7a363043
https://hg.mozilla.org/mozilla-central/rev/6ef880c3361e
https://hg.mozilla.org/mozilla-central/rev/8ce9c39a01cc
https://hg.mozilla.org/mozilla-central/rev/46f3fb297eee
https://hg.mozilla.org/mozilla-central/rev/70e571a4d115
https://hg.mozilla.org/mozilla-central/rev/b21b6ee4cd76
https://hg.mozilla.org/mozilla-central/rev/e505acd05133
https://hg.mozilla.org/mozilla-central/rev/609d8edb3283
https://hg.mozilla.org/mozilla-central/rev/028810114451
https://hg.mozilla.org/mozilla-central/rev/3119dda70eb8
https://hg.mozilla.org/mozilla-central/rev/3f0c9544000e
https://hg.mozilla.org/mozilla-central/rev/f2b1698faa37
https://hg.mozilla.org/mozilla-central/rev/277e23f39103
https://hg.mozilla.org/mozilla-central/rev/bbd0092e97a3
https://hg.mozilla.org/mozilla-central/rev/e2972b033db7
https://hg.mozilla.org/mozilla-central/rev/90cbfb6edeef