1969100 - Triple-click line selection no longer works properly on unstyled (tree view) XML sitemaps

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect)

Description

[pokechu022]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:139.0) Gecko/20100101 Firefox/139.0

Steps to reproduce:

1. Navigate to e.g. https://example.myshopify.com/sitemap.xml
2. Triple-click the text "https://example.myshopify.com/sitemap_products_1.xml?from=4450&to=4450"

Actual results:

A word gets selected on the second click, and then the selection gets cleared on the 3rd click (Firefox 139)/the full page appears to be selected but isn't (Nightly 141).

Expected results:

The line should be selected. (Since the sitemap has no styles, this is the only way to actually select the text to navigate to the other sitemap). In prior versions, this might include or exclude the <loc> tags depending on if the text was wrapped (see https://example.myshopify.com/sitemap_products_1.xml?from=4450&to=4450 for an example); IMO it would be better to never include the surrounding tags.

This regressed with https://phabricator.services.mozilla.com/D244519 / bug 1958639 (for Firefox 139), and further regressed with bug 1932150 (mozregression points to https://phabricator.services.mozilla.com/D231591 but I think it's a different change associated with that ticket).

Comment 1

[Sean Feng [:sefeng211]]

Yeah..thanks for the bug report. I'll take a look about this.

Comment 2

[Sean Feng [:sefeng211]]

Probably I should let emilio to handle this bug because the change made in bug 1958639 was the cause here..

Should we allow NAC for static XML document to be paragraph selected ?

Thoughts Emilio?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1969100 - Don't ignore UA-widget nodes for paragraph selection. r=masayuki,sefeng,#layout

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2999dac529f
Don't ignore UA-widget nodes for paragraph selection. r=sefeng

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b2999dac529f

Comment 6

[pokechu022]

This is actually something I use surprisingly often, on the order of multiple times a day (though I imagine I'm the exception and the vast majority of people never even look at an XML sitemap, let alone try to select something in it). Is there any chance that this could be included in the next 139 release (assuming one happens), or is it too niche for that?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9491504 [details]
Bug 1969100 - Don't ignore UA-widget nodes for paragraph selection. r=masayuki,sefeng,#layout

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: One liner fix for a regression recently introduced.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9491504 [details]
Bug 1969100 - Don't ignore UA-widget nodes for paragraph selection. r=masayuki,sefeng,#layout

Approved for 140.0b4.

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/eca440806a37
https://hg.mozilla.org/releases/mozilla-beta/rev/984f6e27a363

Comment 10

[Giorgia Nichita, Release Desktop QA]

I was able to reproduce this issue on an affected Nightly build from 2025-05-28 on Windows 10. I have verified that the issue is fixed in both Nightly 141.0a1 (20250602211130) and Firefox 140.0b4 (20250602090557) across multiple platforms: Windows 10, Windows 11, macOS 11, and Ubuntu 22.04. Triple-click selection now works correctly, selecting the entire line as expected.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9491504 [details]
Bug 1969100 - Don't ignore UA-widget nodes for paragraph selection. r=masayuki,sefeng,#layout

Approved for 139.0.4

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/eb6d2a0e495f
https://hg.mozilla.org/releases/mozilla-release/rev/6fc9e64bc557

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Added to the 139.0.4 relnotes.

Fixed various selection issues when triple-clicking text in some situations.

Comment 14

[Giorgia Nichita, Release Desktop QA]

Verified as fixed using Firefox 139.0.4-build1 (20250609112858) on Windows 10, Windows 11, macOS 11, and Ubuntu 22.04.
Triple-clicking now correctly selects the entire line as expected.