1969260 - After screen rotation to portrait the URL is slow to focus the domain

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: SlowToScrollDomain.mp4

Steps to reproduce

1. Access a URL with a long subdomain and a long domain
2. Observe that when in portrait the last part of the domain will be shown
3. Rotate the screen to landscape and then to portrait

Expected behavior

The same as before - the last part of the domain will be shown

Actual behavior

For some seconds, until other toolbar is interacted with / webpage is reloaded the subdomain is shown.

Device information

Firefox version: Issue is for now particular to v. 141 as it follows a recent feature.

Any additional information?

The time needed for the URL to scroll to the last part of the domain can vary a lot.

Comment 1

[Michel Le Bihan]

I think that we should override onSizeChanged or onLayout and call scrollToShowRegistrableDomain there. I'm not sure about where it is better to do that.

Comment 2

[Michel Le Bihan]

There seems to be a broader issue with the toolbar refresh that I reported in https://bugzilla.mozilla.org/show_bug.cgi?id=1969437

Comment 3

[Michel Le Bihan]

Attachment: Bug 1969260 - Scroll URL when layout is changed in Android Toolbar. r=petru

Comment 4

[Michel Le Bihan]

Could you please review the proposed solution in the attached revision?

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Thank you for the quick fix!
Approved the patch.
Sensible solution which should avoid any other related issues.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c0ebe7d5c24f
https://hg.mozilla.org/integration/autoland/rev/74954c6f3d63
Scroll URL when layout is changed in Android Toolbar. r=petru,android-reviewers

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/74954c6f3d63