1969467 - Menu > View > Full Screen check mark is remaining even after full-screen has been exited

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Alice0775 White]

Attachment: screenshot

Steps to reproduce:

1. Enable Menubar
2. Click on View of menubar and click on Full Screen so that the browser will full screen mode
3. Press F11 (or right click on tabbar and choose Exit Full Screen Mode ) to exit full screen mode
4. Click on View of menubar

Actual Results:
Full Screen menu check mark is remaining

Expected Results:
The check mark should be removed

Regression window:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=4e7e66244ab0c439df0ff2509869dbe618f0a2f8&tochange=c93409bff9e98d52646d62fc9816b4f130c056ad

Comment 1

[Alice0775 White]

Also reproduced on Nightly 141.0a1 Linux Mint 22 Cinnamon.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:simonf, since you are the author of the regressor, bug 1932640, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Simon Friedberger [:simonf]]

Attachment: Bug 1969467: Fix checkmark on Full Screen menu item r=gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0e3e3b38fcff
https://hg.mozilla.org/integration/autoland/rev/72a4c0891e71
Fix checkmark on Full Screen menu item r=Gijs

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/72a4c0891e71

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:simonf, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox140 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Bogdan Maris, Desktop Test Engineering [OUT until 12 Jan]]

Reproduced the initial issue from comment 0 using and old Nightly build from 2025-05-30. Verified that this is now fixed using latest Nightly 142.0a1 and Firefox 141.0b4 on Windows 11 and Ubuntu 22.04.
I did not see a checkmark on Mac though using Nightly 142.0a1 (I know there is the regression bug 1973740 for mac), I am questioning if there exists one for Enter Full Screen or not in the first place, I checked with esr128 as well and no indeed there is no checkmark probably never was. Simon do you know anything about this?

Comment 8

[Simon Friedberger [:simonf]]

There should not be a check mark on Mac. On Mac we instead rename the menu entry to "Enter Full Screen" and "Exit Full Screen" depending on context. According to Gijs this is a platform convention on Mac.

Comment 9

[Bogdan Maris, Desktop Test Engineering [OUT until 12 Jan]]

(In reply to Simon Friedberger (:simonf) from comment #8)

There should not be a check mark on Mac. On Mac we instead rename the menu entry to "Enter Full Screen" and "Exit Full Screen" depending on context. According to Gijs this is a platform convention on Mac.

Thanks for the confirmation.