1973740 - Enter Full Screen and Exit Full Screen in MacOS menu do nothing

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Simon Friedberger [:simonf]]

Strangely the attached key combination still works.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1969467

Comment 2

[Simon Friedberger [:simonf]]

Attachment: Bug 1973740: Fix full screen menu entries on Mac r?gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/91f2490de301
https://hg.mozilla.org/integration/autoland/rev/6f444e37b3af
Fix full screen menu entries on Mac r=Gijs

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6f444e37b3af

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:simonf, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox141 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Simon Friedberger [:simonf]]

Attachment: Bug 1973740: Fix full screen menu entries on Mac r?gijs

Original Revision: https://phabricator.services.mozilla.com/D254872

Comment 7

[Pascal Chevrel:pascalc]

Simon, is https://phabricator.services.mozilla.com/D255623 meant for uplift to beta? There is no uplift request form, so maybe this is a bug. Thanks

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Menu item in the view menu is broken on Mac
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: click on the menu entry "Enter Full Screen" and "Exit Full Screen"
• Risk associated with taking this patch: smallish
• Explanation of risk level: there are automated tests now, and the code change itself is small
• String changes made/needed: no
• Is Android affected?: no

Comment 9

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Menu item in the view menu is broken on Mac
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: click on the menu entry "Enter Full Screen" and "Exit Full Screen"
• Risk associated with taking this patch: smallish
• Explanation of risk level: there are automated tests now, and the code change itself is small
• String changes made/needed: no
• Is Android affected?: no

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Menu item in the view menu is broken on Mac
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: click on the menu entry "Enter Full Screen" and "Exit Full Screen"
• Risk associated with taking this patch: smallish
• Explanation of risk level: there are automated tests now, and the code change itself is small
• String changes made/needed: no
• Is Android affected?: no

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Menu item in the view menu is broken on Mac
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: smallish
• Explanation of risk level: There are automated tests now, and the code change itself is small.
• String changes made/needed: No
• Is Android affected?: no

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/6d79ed2ffaef
https://hg.mozilla.org/releases/mozilla-beta/rev/952e2ac6a0c5