Closed Bug 1969587 Opened 2 months ago Closed 2 months ago

Add Trending Search feature toggle to Customizaton Panel and about:preferences#home Settings page

Categories

(Firefox :: New Tab Page, task)

task

Tracking

()

VERIFIED FIXED
141 Branch
Tracking Status
firefox141 --- verified

People

(Reporter: maxx, Assigned: npypchenko)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Add toggle switch to customization panel and settings page

(Note: Feel free to break this bug into two patches as the Settings page will have different required reviews)

Figma designs:

Assignee: nobody → npypchenko
Status: NEW → ASSIGNED
Pushed by nbarrett@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/dc3abb88ad4d https://hg.mozilla.org/integration/autoland/rev/fb2065450da0 Add Trending Search feature toggle to Customization Panel and about:preferences#home Settings page r=home-newtab-reviewers,fluent-reviewers,settings-reviewers,bolsson,mconley,nbarrett
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch

Hi, Nina! I have verified this task using the latest Firefox Nightly 141.0a1 (Build ID: 20250612214230) build on Windows 10 x64, macOS 14.7.1, and Ubuntu 24.04.1, and I didn’t manage to see the “Trending on Google” toggle either on the “about:preferences#home” page or in the Customization Panel.
Could you please let me know if the testing steps from the Test Plan are correct?

Flags: needinfo?(npypchenko)
Regressions: 1972085

I no longer need extra information, as I'm now able to enable the "Trending searches” toggle. I'll verify this task as soon as Bug 1972085 is fixed.

Flags: needinfo?(npypchenko)

I have verified this task using the latest Firefox Nightly 141.0a1 (Build ID: 20250619214031) build on Windows 10 x64, macOS 15.5, and Ubuntu 24.04.1.

  • The 'Trending searches' option toggle is displayed and enabled on both the Customization panel and about:preferences#home page while the “browser.newtabpage.activity-stream.trendingSearch.enabled” pref is set to ‘true’.
  • The 'Trending searches' option toggle is displayed and disabled on both the Customization panel and about:preferences#home page while the “browser.newtabpage.activity-stream.trendingSearch.enabled” pref is set to ‘false’.
  • The 'Trending searches' option toggle is not displayed on both the Customization panel and about:preferences#home page, while the Search engine is not Google.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: