1972085 - "Firefox Home Content" checkboxes are blank on about:preferences#home when `system.trendingSearch.enabled` is true

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Maxx Crawford [:maxx]]

Attachment: image.png

STR:

• Set the pref browser.newtabpage.activity-stream.system.trendingSearch.enabled to true
  • It's also expected that your default Search engine should be set to Google
• Open about:preferences#home
• Expected: There should be checkboxes to enable feature for new tab under the "Firefox Home Content" section
• Actual: There are no checkboxes/content in that section.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1969587

:npypchenko, since you are the author of the regressor, bug 1969587, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Maxx Crawford [:maxx]]

Attachment: Bug 1972085 - Update about:preference#home pref logic to show/hide Trending Searches and update how trendingSearch.defaultSearchEngine pref is set r?#home-newtab-reviewers

about:preferences#home uses fully quailifed prefs, while New Tab uses prefs defined in ActivityStream.sys.mjs. The pref trendingSearch.defaultSearchEngine is a mirror of the browser.urlbar.placeholderName pref.

Additionally, the default value of the feature pref should be true. This way, when the feature is enabled via Nimbus (flipping the system.trendingSearch.enabled pref), it will be enabled.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7b5290b2e269
https://hg.mozilla.org/integration/autoland/rev/42c099c309a2
Update about:preference#home pref logic to show/hide Trending Searches and update how trendingSearch.defaultSearchEngine pref is set r=home-newtab-reviewers,nbarrett

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3304dfd52da9
https://hg.mozilla.org/integration/autoland/rev/46a515f40cdf
Revert "Bug 1972085 - Update about:preference#home pref logic to show/hide Trending Searches and update how trendingSearch.defaultSearchEngine pref is set r=home-newtab-reviewers,nbarrett" for causing newtab failures.

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for causing newtab failures.

Push with failures

Failure log

Backout link

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/921bcdff670b
https://hg.mozilla.org/integration/autoland/rev/36d957e83b0b
Update about:preference#home pref logic to show/hide Trending Searches and update how trendingSearch.defaultSearchEngine pref is set r=home-newtab-reviewers,nbarrett

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/36d957e83b0b

Comment 8

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 141.0a1 (Build ID: 20250619214031) build on Windows 10 x64, macOS 15.5, and Ubuntu 24.04.1.

• The "Firefox Home Content" options are displayed in about:preferences#home when system.trendingSearch.enabled is true.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1969587