1969818 - [Crash Reporter] Fenix content process always crash when GeckoView is isolated process build

Status: NEW

(GeckoView :: General, defect, P2)

Description

[Makoto Kato [:m_kato]]

When using isolated process build of GeckoView, Fenix's content process always crash by the following exception.

06-02 15:27:22.795  3217  3217 E AndroidRuntime: java.lang.RuntimeException: Unable to create application org.mozilla.fenix.DebugFenixApplication: java.lang.SecurityException: Isolated process not allowed to call getIntentSender
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5364)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.app.ActivityThread.-wrap2(ActivityThread.java)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1528)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:102)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:154)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6077)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:866)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:756)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: Caused by: java.lang.SecurityException: Isolated process not allowed to call getIntentSender
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.os.Parcel.readException(Parcel.java:1683)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.os.Parcel.readException(Parcel.java:1636)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.app.ActivityManagerProxy.getIntentSender(ActivityManagerNative.java:4637)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.app.PendingIntent.getActivity(PendingIntent.java:342)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.app.PendingIntent.getActivity(PendingIntent.java:302)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at org.mozilla.fenix.components.Analytics.crashReporter_delegate$lambda$2(Analytics.kt:106)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at org.mozilla.fenix.components.Analytics.$r8$lambda$x5HuOztnO17vm8v56YjjO2-UJ6w(Analytics.kt)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at org.mozilla.fenix.components.Analytics$$ExternalSyntheticLambda5.invoke(D8$$SyntheticClass:0)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:83)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at org.mozilla.fenix.components.Analytics.getCrashReporter(Analytics.kt:50)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at org.mozilla.fenix.FenixApplication.setupCrashReporting(FenixApplication.kt:497)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at org.mozilla.fenix.FenixApplication.setupInAllProcesses(FenixApplication.kt:194)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at org.mozilla.fenix.FenixApplication.initialize(FenixApplication.kt:156)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at org.mozilla.fenix.FenixApplication.onCreate(FenixApplication.kt:146)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1024)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5361)
06-02 15:27:22.795  3217  3217 E AndroidRuntime: 	... 8 more

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Ted Campbell [:tcampbell]]

Gabriele, do you think you or someone close to crash reporting could look into this?

Comment 3

[Gabriele Svelto [:gsvelto]]

How urgent is this? It will require a fair amount of work and both me and the others working on crash reporting have their hands full at the moment, but I can plan for the coming months.

Comment 4

[[:owlish] 🦉 PST]

Hi Gabriele, this is part of our current project that we hope to complete this year. If you could plan this for the coming months, that would be great!

Comment 5

[Gabriele Svelto [:gsvelto]]

I replied in bug 1710940, maybe we should duplicate one of the two bugs since they're the same issue (i.e. the crash generator can't ptrace() isolated processes and we need to change the minidump-writer crate to work around it).

Comment 6

[Gabriele Svelto [:gsvelto]]

Actually, I think I was wrong about this. This is about the Java part of the crash reporting code, not the native part which is what I mentioned in comment 5. I think we might need another person to work on this.

Comment 7

[Olivia Hall [:olivia]]

I plan on suppressing the crash reporter for isolated processes for now in bug 1984075, since this seems like a larger unit of work and we'd like to get information on other parts of Fenix + Isolated Processes. (This crash of the crash reporter occurs early in the stack and appears blocking to me.)

Comment 8

[Olivia Hall [:olivia]]

Attachment: Bug 1984075 - Suppress Crash Reporter in Isolated Processes on Fenix

Enabling isolated processes on Fenix are still in the early stages.
This bug suppresses the crash reporter on isolated processes to advance
the app past the crash it causes.

Comment 9

[Phabricator Automation]

Comment on attachment 9508137 [details]
Bug 1984075 - Suppress Crash Reporter in Isolated Processes on Fenix

Revision D261732 was moved to bug 1984075. Setting attachment 9508137 [details] to obsolete.

Comment 10

[Makoto Kato [:m_kato]]

As long as looking AC's crash service, we use Intent to launch crash service. We may have to have something crash helper in GeckoView to run Intent or service.

Comment 11

[Makoto Kato [:m_kato]]

If native crash, we will call ContentDelegate.onCrash(). But if Java's uncaughtException, we might be catch it by Java's crash handler. I guess that we may have to have an API like onJavaUncaughtException() in ContentDelegate, to catch content process's UncaughException on parent process.

Fenix's Crash handler is installed on content process too, then it call Thread.setDefaultUncaughtException, then it will use Intent to notify a lot of things (telemetry, device notification and etc). Isolated process doesn't allow all, so we might have to re-connect to parent process.

Comment 12

[Olivia Hall [:olivia]]

Bug 1992765 also introduced another if clause that needs to be removed once the crash reporter is working.