Open Bug 1969857 Opened 1 year ago Updated 8 months ago

12.28 - 5.38% espn loadtime / bild-de LastVisualChange + 2 more (Android) regression on Mon May 19 2025

Categories

(Core :: DOM: Navigation, defect)

Firefox 140
All
Android
defect

Tracking

()

Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox-esr140 --- disabled
firefox139 --- unaffected
firefox140 --- disabled
firefox141 --- disabled
firefox142 --- disabled
firefox143 --- disabled

People

(Reporter: intermittent-bug-filer, Unassigned, NeedInfo)

References

Details

(4 keywords, Whiteboard: [fxdroid][group1] )

Perfherder has detected a browsertime performance regression from push e5b599370ade4fd1fac7cbe07791c4f8159cc959. As author of one of the patches included in that push, we need your help to address this regression.

Please acknowledge, and begin investigating this alert within 3 business days, or the patch(es) may be backed out in accordance with our regression policy. Our guide to handling regression bugs has information about how you can proceed with this investigation.

If you have any questions or need any help with the investigation, please reach out to fbilt@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
12% espn loadtime android-hw-a55-14-0-aarch64-shippable warm webrender 499.96 -> 561.36
8% espn loadtime android-hw-a55-14-0-aarch64-shippable fission warm webrender 523.54 -> 566.60
8% espn loadtime android-hw-a55-14-0-aarch64-shippable warm webrender 508.36 -> 546.61
5% bild-de LastVisualChange android-hw-a55-14-0-aarch64-shippable warm webrender 1,681.20 -> 1,771.71

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
5% bild-de loadtime android-hw-a55-14-0-aarch64-shippable warm webrender 831.54 -> 789.83

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask fbilt@mozilla.com to do that for you.

You can run all of these tests on try with ./mach try perf --alert 45313

The following documentation link provides more information about this command.

Flags: needinfo?(jajohnson)

Set release status flags based on info from the regressing bug 1961377

It has been over 7 days with no activity on this performance regression.

:jajohnson, since you are the author of the regressor, bug 1961377, which triggered this performance alert, could you please provide a progress update?

If this regression is something that fixes a bug, changes the baseline of the regression metrics, or otherwise will not be fixed, please consider closing it as WONTFIX. See this documentation for more information on how to handle regressions.

For additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in #perftest, or #perfsheriffs on Element.

For more information, please visit BugBot documentation.

Flags: needinfo?(jajohnson)
Flags: needinfo?(jajohnson)
Flags: needinfo?(fbilt)

I just finished the bisection process, and it seems that the regression was caused by the revision flagged by you.
Apologies for the confusion.
I will change the regression by field.

Flags: needinfo?(fbilt)
Regressed by: 1962710
No longer regressed by: 1961377

:farre, there is little time to fix this since the final beta builds tomorrow. Appreciate if you could take a look?

Flags: needinfo?(afarre)

I'll have to look at this closer, but immediately this feels strange since the regressing bug's patch is behind a pref.

Does someone know if perfherder runs with the navigation API pref on?

Flags: needinfo?(aaron.train)

I'm unfamiliar with Perfherder environment. I assume someone on #perf-help would know. Moving this to Core.

Component: UI Tests → DOM: Navigation
Flags: needinfo?(aaron.train)
Product: Firefox for Android → Core
Version: unspecified → Firefox 140

Set release status flags based on info from the regressing bug 1962710

I started a performance comparison with SHIP off for android to see if we get the performance back. If that's the case, this performance regression is the same as bug 1968988

Flags: needinfo?(afarre) → needinfo?(dmeehan)

Thanks. If that's the case, we can set the regressor correctly (Bug 1951246) and mark Fx140 as disabled.

Flags: needinfo?(dmeehan)

Setting to S2 as same as bug 1968988.

Severity: -- → S2

Set release status flags based on info from the regressing bug 1951246

It has been over 7 days with no activity on this performance regression.

:kaya, since you are the author of the regressor, bug 1951246, which triggered this performance alert, could you please provide a progress update?

If this regression is something that fixes a bug, changes the baseline of the regression metrics, or otherwise will not be fixed, please consider closing it as WONTFIX. See this documentation for more information on how to handle regressions.

For additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in #perftest, or #perfsheriffs on Element.

For more information, please visit BugBot documentation.

Flags: needinfo?(kkaya)

The issue seems to be happening due to bfcache in parent. I am still debugging the flow. (as in Bug 1968988)

Flags: needinfo?(kkaya)

It has been over 7 days with no activity on this performance regression.

:kaya, since you are the author of the regressor, bug 1951246, which triggered this performance alert, could you please provide a progress update?

If this regression is something that fixes a bug, changes the baseline of the regression metrics, or otherwise will not be fixed, please consider closing it as WONTFIX. See this documentation for more information on how to handle regressions.

For additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in #perftest, or #perfsheriffs on Element.

For more information, please visit BugBot documentation.

Flags: needinfo?(kkaya)
Assignee: nobody → kkaya
Flags: needinfo?(kkaya)
Priority: -- → P1
Whiteboard: [fxdroid][group1]

Adjusted the severity given it's currently disabled, though it's still a high priority we're actively working on.

Severity: S2 → S3

Hi Andreas, just to make sure: was it confirmed by your comparison that SHIP was the problem? (just looking at the discussion here, it seems like the the regressor bug was changed to the SHIP one 3 minutes after your message, but I can't tell if the comparison was finished by then, and also I cannot seem to be able to see the results of the comparison now) Thanks!

Flags: needinfo?(afarre)

I can't recall, I'll have to defer to kaya or smaug. The thing I can say is that this has nothing to do with the commit indicated in comment 3, since that code is preffed off.

Flags: needinfo?(smaug)
Flags: needinfo?(kkaya)
Flags: needinfo?(afarre)

Hey folks, I checked this (try pushes: recent rebase and the recent rebase with SHIP on), and it looks like SHIP is not at fault here. The espn and build-de failures appear as intermittent in both cases. I think this bug has nothing to do with SHIP.

This is definitely not the bug I've been looking at when it comes to SHIP. loadtime isn't very useful metric.

Flags: needinfo?(smaug)
No longer regressed by: 1951246

Thank you for the clarification, Olli! I cleared the regression field, because this is not related to SHIP.

Assignee: kkaya → nobody

I removed Kaya from assigned because as this does not seem to be related to SHIP, Kaya should not be working on this.

Severity: S3 → --
Priority: P1 → --

To be honest, loadtime as a metric is almost totally worthless; random timing issues can cause later requests to be in the load group, and if so they extend loadtime, sometimes significantly, with little or no user impact other than the loading indicator stays on longer

You need to log in before you can comment on or make changes to this bug.