1951246 - Enable SHIP on Firefox Android by default

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Comment 1

[Kaya [:kaya]]

Attachment: Bug 1951246 - Enable SHIP on Fenix by default.

Comment 2

[Kaya [:kaya]]

• set the disableSessionHistoryInParent in StaticPrefList to true for Android && NOT_NIGHTLY
• change the Nimbus ship pref for nightly&dev channel to false by default
• make sure nofis-noship test coverage is still satisfied, as we still have users in that variant (on Beta and Release channels).

Comment 3

[Kaya [:kaya]]

Update:
Instead of enabling SHIP only on Nightly, I've decided to let it ride the train - considering the results we have from the release experiments.
Therefore, the adjustments stated in Comment 2 needs modification:

• set the disableSessionHistoryInParent in StaticPrefList to false
• set the disable SHIP Nimbus flag to false (note that a new ticket is created that's blocked by this ticket for a follow-up clean up the SHIP-disabling code, including this Nimbus flag)
• make sure nofis-noship test coverage is still satisfied, as we still have users in that variant (on Beta and Release channels).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e2411ffd6d0
Enable SHIP on Fenix by default. r=taskgraph-reviewers,android-reviewers,jmaher,owlish

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/52633 for changes under testing/web-platform/tests

Comment 6

[Cristina Horotan [:chorotan]]

Backed out for causing Wr failures

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9908e2731bd
Enable SHIP on Fenix by default. r=taskgraph-reviewers,android-reviewers,jmaher,owlish,emilio

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d9908e2731bd

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Donal Meehan [:dmeehan]]

:kaya is there anything you want to mention in a release note? (Process info)

Comment 11

[Kaya [:kaya]]

Hi Donal,
Thanks for mentioning that. Yes, I'll try to come up with the wording today. It will something like "an infrastructural change over how the tab and browser session history is handled". I should post the final wording (over the relnote flag) by the EOD. Not clearing the ni until then.

Comment 12

[Kaya [:kaya]]

Release Note Request (optional, but appreciated)
[Why is this notable]: This changes the infrastructure of how we are dealing with the session history on Android. Any history related operations (including back/forward navigation) will be impacted.
[Affects Firefox for Android]: yes
[Suggested wording]: An infrastructural change over how the tab session history is stored and handled behind the scenes. This change is mostly under the hood, so users should not notice any visible differences.
[Links (documentation, blog post, etc)]:

Comment 13

[Donal Meehan [:dmeehan]]

Discussed offline, this is a transparent change to users, and there's no specific benefit to call out.

Comment 14

[Kaya [:kaya]]

Attaching another ticket, which disables SHIP on Beta and Release until we figure out the cause of the performance regression.

Comment 15

[[:owlish] 🦉 PST]

Reopening as SHIP was rolled back, and not enabled by default yet

Comment 16

[Hiroyuki Ikezoe (:hiro)]

FWIW, while I was investigating bug 1996198, with enabling SHIP BrowsingContext::IsActive returns true for browsing contexts in BFCache. The isActive is used in a lot of places. Some of bugs blocking this bug might be relevant with it.

Comment 17

[Hiroyuki Ikezoe (:hiro)]

Adding bug 1996198 into the dependency list since I don't think we don't want regress bug 1996198 when we enable SHIP by default.

Comment 18

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #16)

FWIW, while I was investigating bug 1996198, with enabling SHIP BrowsingContext::IsActive returns true for browsing contexts in BFCache. The isActive is used in a lot of places. Some of bugs blocking this bug might be relevant with it.

FYI, now the isActive flag issue was solved in bug 1997214.