1970055 - Inconsistent browser history menu when long clicking on the navigation buttons

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P1)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: InconsistentHistoryNavigationMenuFromToolbar.mp4

Steps to reproduce

1. Use a tablet to get the navigation buttons to be shown in the toolbar
2. Access different webpages in the same tab
3. Long press on the active navigation buttons

Expected behavior

A popup with all the history for that tab appears at the bottom of the screen

Actual behavior

Sometimes the popup is empty

Any additional information?

In my limited tries I could easily reproduce this on Nightly and Beta but not on Release suggesting this is a recent regression.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: InconsistentHistoryNavigationMenuFromMenu.mp4

This reproduces also when interacting with the navigation buttons from the redesigned menu.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[[:harrisono]]

Attachment: Bug 1970055 - Fix TabHistoryDialogFragment not pulling full history on tablet

Comment 4

[[:harrisono]]

Attachment: Bug 1970055 - Fix TabHistoryDialogFragment not pulling full history on tablet

Comment 5

[[:harrisono]]

on re-examining, I'm discovering that the call inside TabHistoryDialogFragment to the selectedTab history is not gathering updated history when initially called and the history is updated by geckoview later which then flows into TabHistoryDialogFragment and loads the data after a bit. This happens if a user long presses the nav button immediately upon navigating through a series of pages

if a user waits on a page for about 5 seconds, the TabHistoryDialogFragment will be opened without issue.

Comment 6

[[:harrisono]]

Attachment: logHistoryStateTabHistoryDialog.txt

A log showing the change in history state as the history is loaded and sent from GeckoView to Fenix observers.

Comment 7

[[:owlish] 🦉 PST]

We discussed this on Slack a bit - this is a SHIP bug.

Comment 8

[Kaya [:kaya]]

Attachment: Bug 1970055 - Flush engine session state for the selected tab when the back and forward navigation buttons are long pressed to fetch the most recent session state.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ea7f83ab9aa3
https://hg.mozilla.org/integration/autoland/rev/2cb7ca176216
Flush engine session state for the selected tab when the back and forward navigation buttons are long pressed to fetch the most recent session state. r=geckoview-reviewers,android-reviewers,geckoview-api-reviewers,ohall,sfamisa,nalexander

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2cb7ca176216