1970400 - [Menu redesign 2025] Implement accessibility for all the menu items

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, task)

Description

[[:skhan]]

Verify and add all the accessibility items needed.
We will need to verify/add screen reader annotations, focus order, and whether interactive elements are properly labeled and navigable
https://www.figma.com/design/FWc4e0Z7ZZZOQwTxkhWo34/Menu-Handoff--WIP-?node-id=8335-9356&t=RNNmT6qsCDhBrjgj-4

Comment 1

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 1970400 - Implement accessibility for all the menu items.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ffe1e2da6757
https://hg.mozilla.org/integration/autoland/rev/e9b77924bb50
Implement accessibility for all the menu items. r=android-reviewers,android-l10n-reviewers,skhan,delphine,ajoltan,aaronmt

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e9b77924bb50

Comment 10

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 1970400 - Implement accessibility for all the menu items.

Original Revision: https://phabricator.services.mozilla.com/D254463

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Users won't have the correct accessibility functionality for the menu.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Allow talkback and access menu and compare functionality with figma. More detailed steps available in the bugs marked as duplicate and see also on this bug.
• Risk associated with taking this patch: Low
• Explanation of risk level: Only changes accessibility features.
• String changes made/needed: Yes
• Is Android affected?: no

Comment 12

[Pascal Chevrel:pascalc]

Flod, there are string changes in this uplift request, could your team chime in? Not sure who is in charge for Android string changes approvals. Thanks!

Comment 13

[Francesco Lodolo [:flod]]

That would be Delphine (see also this page). Redirecting to her.

Is Android affected?: no

That's wrong, given the component?

Comment 14

[Aaditya Dhingra [:adhingra]]

From what I understand, this meant if the patch affects android device for example notifications or doing something related to battery. so in this case, it would be no. Please correct me if I am wrong!

Comment 15

[Delphine Lebédel [:delphine - Use needinfo]]

I checked and these strings have already been translated in most languages, so they should already be in Beta. So in this case, it's safe to uplift.

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/d48baf1d825a
https://hg.mozilla.org/releases/mozilla-beta/rev/ab32f98a4673

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/61a60f98109d
https://hg.mozilla.org/releases/mozilla-beta/rev/83a894c1748d

Comment 18

[Pascal Chevrel:pascalc]

This is backed out for causing Fenix build failures in CI:
https://treeherder.mozilla.org/jobs?repo=mozilla-beta&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ab32f98a46735295222cf0f8998b7193d689b044&selectedTaskRun=J3kCbzVGQ6qmUbs1bvqUsg.0

Comment 19

[Aaditya Dhingra [:adhingra]]

Updated the patch, sorry about that, can we try again?

Comment 20

[Pascal Chevrel:pascalc]

Comment on attachment 9499534 [details]
Bug 1970400 - Implement accessibility for all the menu items.

We are out of betas.

Comment 21

[Vasilica Tamas (Android QA) [:vtamas]]

This issue is verified as fixed on Firefox for Android 142 (2025-07-20) on Samsung S24 Ultra (Android 15). Confirmed the results with :adhingra on Slack and filed a follow-up issue: Bug 1978365.

Comment 22

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/84d7d405e95a
https://hg.mozilla.org/releases/mozilla-release/rev/ec33d4708645

Comment 23

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2aad0f82e663
https://hg.mozilla.org/releases/mozilla-release/rev/cc3b1a2211e1

Comment 24

[Pascal Chevrel:pascalc]

The updated patch is still causing build failures and I had to revert the uplift.

From the failure log:
https://treeherder.mozilla.org/logviewer?job_id=519757031&repo=mozilla-release

[task 2025-07-28T07:46:23.461+00:00] FAILURE: Build failed with an exception.
[task 2025-07-28T07:46:23.461+00:00] 
[task 2025-07-28T07:46:23.461+00:00] * What went wrong:
[task 2025-07-28T07:46:23.461+00:00] Execution failed for task ':app:compileFenixDebugKotlin'.
[task 2025-07-28T07:46:23.461+00:00] > A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
[task 2025-07-28T07:46:23.461+00:00]    > Compilation error. See log for more details
[task 2025-07-28T07:46:23.461+00:00] 
[task 2025-07-28T07:46:23.461+00:00] * Try:
[task 2025-07-28T07:46:23.461+00:00] > Run with --stacktrace option to get the stack trace.
[task 2025-07-28T07:46:23.461+00:00] > Run with --info or --debug option to get more log output.
[task 2025-07-28T07:46:23.461+00:00] > Run with --scan to get full insights.
[task 2025-07-28T07:46:23.461+00:00] > Get more help at https://help.gradle.org.
[task 2025-07-28T07:46:23.461+00:00] 
[task 2025-07-28T07:46:23.461+00:00] Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
[task 2025-07-28T07:46:23.461+00:00] 
[task 2025-07-28T07:46:23.461+00:00] You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
[task 2025-07-28T07:46:23.461+00:00] 
[task 2025-07-28T07:46:23.461+00:00] For more on this, please refer to https://docs.gradle.org/8.14.2/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

Unless we have a fix today before we build 141.0.1, the next target release for a working patch would be next week and 141.0.2.
Aaditya could you look at it please?

Comment 25

[Aaditya Dhingra [:adhingra]]

Hey, sorry we don't want to uplift this. Abandoned the patch! Sorry for the confusion!