1970447 - Saving and closing the last group with insertAfterCurrent=true and closeWindowWithLastTab=false creates a copy of the group

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Dave Townsend [:mossop]]

Attachment: Screen Recording

See the attached video.

If the only thing in the tab strip is groups (no tabs outside of groups) and all but one group is collapsed then attempting to close that last group causes a new tab to open in the group.

Comment 1

[Dave Townsend [:mossop]]

Perhaps related. If the tab strip contains a single group, no other tabs, then choosing "Save and close group" closes the group but then a new group with the same name appears with a new tab in it. The all tabs menu now shows two groups of the same name.

Comment 2

[Negritas Sergiu, Desktop QA]

Hello! I have tried to reproduce the the issue with the steps from the video but unfortunately I wasn't able to with firefox 141.0a1(2025-06-06) on Ubuntu 22.04
Could you please answer the following questions in order to further investigate this issue?

1. Does this issue happen with a new profile? Here is a link on how to create one: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
2. Could you please provide the OS you have encountered this issue?
3. Are you trying to close the group with the middle click button?

Comment 3

[Dave Townsend [:mossop]]

Looks like this is a side effect of setting browser.tabs.insertAfterCurrent to true.

Comment 4

[Dave Townsend [:mossop]]

Bug 1949401 has resolved the original issue here, the secondary issue remains though:

1. Set browser.tabs.insertAfterCurrent to true
2. Set browser.tabs.closeWindowWithLastTab to false
3. Have a window with a single tab group in it and no ungrouped tabs
4. Save and close the group

Here we would expect the window to remain open (because closeWindowWithLastTab is false) and a new tab to be created. What actually happens is a copy of the existing group is created with the new tab inside it.

Comment 5

[Dave Townsend [:mossop]]

Attachment: Bug 1970447: When closeWindowWithLastTab=false and closing the last group make sure the new tab is created outside the group. r=#tabbrowser-reviewers!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1ee9ac69936e
https://hg.mozilla.org/integration/autoland/rev/b336904dc2bc
When closeWindowWithLastTab=false and closing the last group make sure the new tab is created outside the group. r=tabbrowser-reviewers,dwalker

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b336904dc2bc