1970647 - Add allow-list checkboxes to ETP "strict" and "custom" sections in about:preferences#privacy

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement, P2)

Description

[Emma Zühlcke [:emz]]

Draft:

[ ] Allow Firefox to automatically apply exceptions required to avoid major website breakage. (Learn more)
This would be checked by default when users switch to ETP-Strict.
When unchecking: WARNING: Running Firefox in ETP-Strict mode with automatic exceptions turned off is not a recommended configuration and sites may break.
[ ] Also apply exceptions automatically that are only required to fix minor issues and make convenience features available.

Should be in ETP “strict” section and “custom” section under tracking protection option

The checkboxes should control platform level prefs which the allow-list implementation can check.

Comment 1

[Leo Liu [:leoliu]]

Attachment: Bug 1970647 - Add checkboxes to ETP Strict and Custom sections in about:preferences#privacy.

Comment 2

[Emma Zühlcke [:emz]]

We should also make it so that the allow-list category prefs get reset when the user switches to ETP "standard". Here is the code that currently handles setting the prefs for the ETP categories: https://searchfox.org/mozilla-central/source/browser/components/protections/ContentBlockingPrefs.sys.mjs

Comment 3

[Leo Liu [:leoliu]]

Attachment: Desktop-strict

Comment 4

[Leo Liu [:leoliu]]

Attachment: Desktop-custom

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/61711eafed25
https://hg.mozilla.org/integration/autoland/rev/795b34a6d94b
Add checkboxes to ETP Strict and Custom sections in about:preferences#privacy. r=emz,fluent-reviewers,settings-reviewers,anti-tracking-reviewers,bolsson,mstriemer
https://github.com/mozilla-firefox/firefox/commit/9f6dd6eb4372
https://hg.mozilla.org/integration/autoland/rev/9589cef811df
1970921: apply code formatting via Lando

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/95e56be5e2f3
https://hg.mozilla.org/integration/autoland/rev/977131347c7e
Revert "Bug 1970647, 1970921: apply code formatting via Lando" for causing bc failures @ browser_statePartitioning_strings.js

Comment 7

[amarc]

Backed out for causing bc failures @ browser_statePartitioning_strings.js

• Backout link
• Push with failures
• Failure Log

Comment 8

[Leo Liu [:leoliu]]

Fixed test browser_statePartitioning_strings.js by replacing content-blocking-and-isolating-etp-warning-description-2 with content-blocking-and-isolating-etp-warning-description-3

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/909cbfacf7a3
https://hg.mozilla.org/integration/autoland/rev/3c18007439a4
Add checkboxes to ETP Strict and Custom sections in about:preferences#privacy. r=emz,fluent-reviewers,settings-reviewers,anti-tracking-reviewers,bolsson,mstriemer

Comment 10

[pstanciu]

Backed out for causing bc failures @ browser_storageAccessWithDynamicFpi.js

• https://hg.mozilla.org/integration/autoland/rev/cd216ebfcfda1de3bee20d52c48f07593c5c3f8a
• Push with failures
• Failure Log

Comment 11

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/3c18007439a4

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1d89274e682d
https://hg.mozilla.org/integration/autoland/rev/ae76ad8ffdf5
Add checkboxes to ETP Strict and Custom sections in about:preferences#privacy. r=emz,fluent-reviewers,settings-reviewers,anti-tracking-reviewers,bolsson,mstriemer

Comment 13

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ae76ad8ffdf5

Comment 14

[Donal Meehan [:dmeehan]]

:leoliu could you consider nominating this for a release note? (Process info)

Comment 15

[Leo Liu [:leoliu]]

Release Note Request (optional, but appreciated)
[Why is this notable]: ETP-Strict mode can sometimes cause websites to break, for example, non-functional buttons or blank pages due to aggressive tracker blocking. To restore site functionality, we are adding flexibility for ETP-Strict users to apply an exceptions list. We've divided these exceptions into 'baseline' (for core site functions) and 'convenience' (for additional features). ETP-Strict users can now choose to apply the baseline exceptions to ensure websites work without sacrificing core privacy protections.
[Affects Firefox for Android]: Yes
[Suggested wording]:
[Links (documentation, blog post, etc)]: https://mozilla.github.io/url-classifier-exceptions-ui/ contains the exception list we maintain and the categorization of each resource

Comment 16

[Dianna Smith [:diannaS]]

Added to 142 release notes which slightly condensed wording

ETP-Strict mode now supports a flexible exception list to fix broken site features caused by tracker blocking. Exceptions are split into baseline (core functionality) and convenience (extra features), letting users choose improved site compatibility without compromising key privacy protections.