1976075 - Fix baseline & convenience prefs being set to default values on startup

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect, P1)

Description

[Leo Liu [:leoliu]]

Initially, when an ETP-strict user upgrades privacy.trackingprotection.allow_list.hasMigratedCategoryPrefs is used to ensure baseline and convenience exceptions are false by default. However, setPrefsToCategory in ContentBlockingPrefs runs on every startup, causing it to overwrite the prefs to their default values. We should do a check to make sure baseline and convenience are only updated when user switches ETP modes or interacting with the checkboxes, not on startup.

Comment 1

[Emma Zühlcke [:emz]]

This affects Nightly only, but we need to fix it before beta.

Comment 2

[Leo Liu [:leoliu]]

Attachment: Bug 1976075 - Fix baseline & convenience prefs being set to default values when ETP user migrates. r?#anti-tracking!

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1970647

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/570a8d62ae6f
https://hg.mozilla.org/integration/autoland/rev/5e2a2fcbba52
Fix baseline & convenience prefs being set to default values when ETP user migrates. r=anti-tracking-reviewers,emz

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5e2a2fcbba52

Comment 7

[Oana Botisan, Desktop QA]

We verified the fix using a treeherder build on macOS 13, Windows 11 and Ubuntu 22. We can't reproduce the issue anymore neither for restart or reopen.