Crash in [@ mozilla::net::Http2StreamBase::AllowFlowControlledWrite]
Categories
(Core :: Networking: HTTP, defect, P1)
Tracking
()
People
(Reporter: aryx, Assigned: kershaw)
References
Details
(Keywords: crash, Whiteboard: [necko-triaged] [necko-priority-queue])
Crash Data
Attachments
(4 external files, 1 obsolete file)
~180 crashes from ~170 installs in the database for Firefox 138.0.x, and continues for 139.0.x. There are also a few crashes for Firefox ESR 128.x.
Crash report: https://crash-stats.mozilla.org/report/index/cf4cfdca-50ea-4387-a76d-ccc3b0250605
Reason:
EXCEPTION_ACCESS_VIOLATION_READ
Top 10 frames:
0 xul.dll mozilla::net::Http2StreamBase::AllowFlowControlledWrite() netwerk/protocol/http/Http2StreamBase.cpp:859
1 xul.dll mozilla::net::Http2StreamBase::UpdateServerReceiveWindow(int) netwerk/protocol/http/Http2StreamBase.cpp:865
2 xul.dll mozilla::net::Http2Session::RecvWindowUpdate(mozilla::net::Http2Session*) netwerk/protocol/http/Http2Session.cpp:1969
3 xul.dll mozilla::net::Http2Session::WriteSegmentsAgain(mozilla::net::nsAHttpSegmentWr... netwerk/protocol/http/Http2Session.cpp:3146
4 xul.dll mozilla::net::nsHttpConnection::OnSocketReadable() netwerk/protocol/http/nsHttpConnection.cpp:1850
4 xul.dll mozilla::net::nsHttpConnection::OnInputStreamReady(nsIAsyncInputStream*) netwerk/protocol/http/nsHttpConnection.cpp:2198
5 xul.dll mozilla::net::nsSocketInputStream::OnSocketReady(nsresult) netwerk/base/nsSocketTransport2.cpp:288
6 xul.dll mozilla::net::nsSocketTransport::OnSocketReady(PRFileDesc*, short) netwerk/base/nsSocketTransport2.cpp:2162
7 xul.dll mozilla::net::nsSocketTransportService::DoPollIteration(mozilla::BaseTimeDura... netwerk/base/nsSocketTransportService2.cpp:1406
7 xul.dll mozilla::net::nsSocketTransportService::Run() netwerk/base/nsSocketTransportService2.cpp:1177
Comment 1•1 year ago
|
||
I'm seeing Google Gemini showing up in the URL field for a number of reports, but nothing super obvious standing out there otherwise.
| Assignee | ||
Comment 3•1 year ago
|
||
(In reply to Dianna Smith [:diannaS] from comment #2)
:kershaw could this be related to bug 1951184?
Indeed, the stacktrace looks the same as bug 1951184. I think this means the patch in bug 1951184 didn't fix this crash.
I'll take this bug.
| Assignee | ||
Comment 4•1 year ago
|
||
I found a case where a stream is removed from mStreamTransactionHash but the stream id in mStreamIDHash is not removed. If a released stream remains in mStreamIDHash, it could lead to this crash.
| Assignee | ||
Comment 5•1 year ago
|
||
| Assignee | ||
Comment 6•1 year ago
|
||
In caase the preivous patch doesn't fix the issue, enabling VerifyStream should help us catch related crashes earlier.
Comment 8•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6fa1190e614e
https://hg.mozilla.org/mozilla-central/rev/58e728a739aa
Updated•1 year ago
|
Comment 9•1 year ago
|
||
The patch landed in nightly and beta is affected.
:kershaw, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
- If no, please set
status-firefox140towontfix.
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 10•1 year ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D252829
Comment 11•1 year ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: Possible crash
- Code covered by automated testing: no
- Fix verified in Nightly: yes
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: N/A
- Risk associated with taking this patch: Low.
- Explanation of risk level: This is a straightforward patch to ensure H2 streams are removed properly.
- String changes made/needed: N/A
- Is Android affected?: yes
Updated•1 year ago
|
| Assignee | ||
Comment 12•1 year ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D252829
| Assignee | ||
Comment 13•1 year ago
|
||
In case the preivous patch doesn't fix the issue, enabling VerifyStream should help us catch related crashes earlier.
Original Revision: https://phabricator.services.mozilla.com/D252832
Comment 14•1 year ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: Possible crash
- Code covered by automated testing: no
- Fix verified in Nightly: yes
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: N/A
- Risk associated with taking this patch: Low
- Explanation of risk level: This is a straightforwad patch.
- String changes made/needed: N/A
- Is Android affected?: yes
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Comment 15•1 year ago
|
||
| uplift | ||
| Assignee | ||
Updated•1 year ago
|
| Reporter | ||
Comment 16•1 year ago
|
||
There are crash reports with this signature for Firefox 1441 and 142. Could you take another look?
| Assignee | ||
Comment 17•1 year ago
|
||
(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #16)
There are crash reports with this signature for Firefox 1441 and 142. Could you take another look?
I'll create a new bug and try to fix this.
Description
•