Closed Bug 1970656 Opened 1 year ago Closed 1 year ago

Crash in [@ mozilla::net::Http2StreamBase::AllowFlowControlledWrite]

Categories

(Core :: Networking: HTTP, defect, P1)

Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
141 Branch
Tracking Status
firefox-esr115 --- wontfix
firefox-esr128 --- wontfix
firefox139 --- wontfix
firefox140 --- fixed
firefox141 --- fixed

People

(Reporter: aryx, Assigned: kershaw)

References

Details

(Keywords: crash, Whiteboard: [necko-triaged] [necko-priority-queue])

Crash Data

Attachments

(4 external files, 1 obsolete file)

~180 crashes from ~170 installs in the database for Firefox 138.0.x, and continues for 139.0.x. There are also a few crashes for Firefox ESR 128.x.

Crash report: https://crash-stats.mozilla.org/report/index/cf4cfdca-50ea-4387-a76d-ccc3b0250605

Reason:

EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames:

0  xul.dll  mozilla::net::Http2StreamBase::AllowFlowControlledWrite()  netwerk/protocol/http/Http2StreamBase.cpp:859
1  xul.dll  mozilla::net::Http2StreamBase::UpdateServerReceiveWindow(int)  netwerk/protocol/http/Http2StreamBase.cpp:865
2  xul.dll  mozilla::net::Http2Session::RecvWindowUpdate(mozilla::net::Http2Session*)  netwerk/protocol/http/Http2Session.cpp:1969
3  xul.dll  mozilla::net::Http2Session::WriteSegmentsAgain(mozilla::net::nsAHttpSegmentWr...  netwerk/protocol/http/Http2Session.cpp:3146
4  xul.dll  mozilla::net::nsHttpConnection::OnSocketReadable()  netwerk/protocol/http/nsHttpConnection.cpp:1850
4  xul.dll  mozilla::net::nsHttpConnection::OnInputStreamReady(nsIAsyncInputStream*)  netwerk/protocol/http/nsHttpConnection.cpp:2198
5  xul.dll  mozilla::net::nsSocketInputStream::OnSocketReady(nsresult)  netwerk/base/nsSocketTransport2.cpp:288
6  xul.dll  mozilla::net::nsSocketTransport::OnSocketReady(PRFileDesc*, short)  netwerk/base/nsSocketTransport2.cpp:2162
7  xul.dll  mozilla::net::nsSocketTransportService::DoPollIteration(mozilla::BaseTimeDura...  netwerk/base/nsSocketTransportService2.cpp:1406
7  xul.dll  mozilla::net::nsSocketTransportService::Run()  netwerk/base/nsSocketTransportService2.cpp:1177

I'm seeing Google Gemini showing up in the URL field for a number of reports, but nothing super obvious standing out there otherwise.

:kershaw could this be related to bug 1951184?

Flags: needinfo?(kershaw)

(In reply to Dianna Smith [:diannaS] from comment #2)

:kershaw could this be related to bug 1951184?

Indeed, the stacktrace looks the same as bug 1951184. I think this means the patch in bug 1951184 didn't fix this crash.
I'll take this bug.

Assignee: nobody → kershaw
Severity: -- → S3
Flags: needinfo?(kershaw)
Priority: -- → P1
Whiteboard: [necko-triaged] [necko-priority-queue]

I found a case where a stream is removed from mStreamTransactionHash but the stream id in mStreamIDHash is not removed. If a released stream remains in mStreamIDHash, it could lead to this crash.

In caase the preivous patch doesn't fix the issue, enabling VerifyStream should help us catch related crashes earlier.

Pushed by kjang@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8d9f7e7b8973 https://hg.mozilla.org/integration/autoland/rev/6fa1190e614e Ensure stream is removed from both mStreamTransactionHash and mStreamIDHash, r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/477e44dae38b https://hg.mozilla.org/integration/autoland/rev/58e728a739aa Enable VerifyStream in early beta builds, r=necko-reviewers,sunil
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch

The patch landed in nightly and beta is affected.
:kershaw, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(kershaw)

firefox-beta Uplift Approval Request

  • User impact if declined: Possible crash
  • Code covered by automated testing: no
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: N/A
  • Risk associated with taking this patch: Low.
  • Explanation of risk level: This is a straightforward patch to ensure H2 streams are removed properly.
  • String changes made/needed: N/A
  • Is Android affected?: yes
Attachment #9494072 - Attachment is obsolete: true

In case the preivous patch doesn't fix the issue, enabling VerifyStream should help us catch related crashes earlier.

Original Revision: https://phabricator.services.mozilla.com/D252832

firefox-beta Uplift Approval Request

  • User impact if declined: Possible crash
  • Code covered by automated testing: no
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: N/A
  • Risk associated with taking this patch: Low
  • Explanation of risk level: This is a straightforwad patch.
  • String changes made/needed: N/A
  • Is Android affected?: yes
Attachment #9494074 - Flags: approval-mozilla-beta+
Attachment #9494073 - Flags: approval-mozilla-beta+
Flags: needinfo?(kershaw)
See Also: → 1976376

There are crash reports with this signature for Firefox 1441 and 142. Could you take another look?

Flags: needinfo?(kershaw)

(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #16)

There are crash reports with this signature for Firefox 1441 and 142. Could you take another look?

I'll create a new bug and try to fix this.

Flags: needinfo?(kershaw)
See Also: → 1987350
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: