Closed
Bug 1987350
Opened 1 year ago
Closed 1 year ago
Crash in [@ mozilla::net::Http2StreamBase::AllowFlowControlledWrite]
Categories
(Core :: Networking: HTTP, defect, P2)
Tracking
()
RESOLVED
FIXED
144 Branch
People
(Reporter: kershaw, Assigned: kershaw)
References
Details
(Keywords: crash, Whiteboard: [necko-triaged] [necko-priority-queue])
Crash Data
Attachments
(2 external files)
~180 crashes from ~170 installs in the database for Firefox 138.0.x, and continues for 139.0.x. There are also a few crashes for Firefox ESR 128.x.
Crash report: https://crash-stats.mozilla.org/report/index/cf4cfdca-50ea-4387-a76d-ccc3b0250605
Reason:
EXCEPTION_ACCESS_VIOLATION_READ
Top 10 frames:
0 xul.dll mozilla::net::Http2StreamBase::AllowFlowControlledWrite() netwerk/protocol/http/Http2StreamBase.cpp:859
1 xul.dll mozilla::net::Http2StreamBase::UpdateServerReceiveWindow(int) netwerk/protocol/http/Http2StreamBase.cpp:865
2 xul.dll mozilla::net::Http2Session::RecvWindowUpdate(mozilla::net::Http2Session*) netwerk/protocol/http/Http2Session.cpp:1969
3 xul.dll mozilla::net::Http2Session::WriteSegmentsAgain(mozilla::net::nsAHttpSegmentWr... netwerk/protocol/http/Http2Session.cpp:3146
4 xul.dll mozilla::net::nsHttpConnection::OnSocketReadable() netwerk/protocol/http/nsHttpConnection.cpp:1850
4 xul.dll mozilla::net::nsHttpConnection::OnInputStreamReady(nsIAsyncInputStream*) netwerk/protocol/http/nsHttpConnection.cpp:2198
5 xul.dll mozilla::net::nsSocketInputStream::OnSocketReady(nsresult) netwerk/base/nsSocketTransport2.cpp:288
6 xul.dll mozilla::net::nsSocketTransport::OnSocketReady(PRFileDesc*, short) netwerk/base/nsSocketTransport2.cpp:2162
7 xul.dll mozilla::net::nsSocketTransportService::DoPollIteration(mozilla::BaseTimeDura... netwerk/base/nsSocketTransportService2.cpp:1406
7 xul.dll mozilla::net::nsSocketTransportService::Run() netwerk/base/nsSocketTransportService2.cpp:1177
Updated•1 year ago
|
Crash Signature: [@ mozilla::net::Http2StreamBase::AllowFlowControlledWrite]
See Also: → 1970656
| Assignee | ||
Comment 1•1 year ago
|
||
Updated•1 year ago
|
Assignee: nobody → kershaw
Status: NEW → ASSIGNED
Pushed by kjang@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/29085fbe048e
https://hg.mozilla.org/integration/autoland/rev/29fdf170f4f6
Keep mInputFrameDataStream alive in Http2Session::RecvWindowUpdate, r=necko-reviewers,valentin
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox144:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 144 Branch
Updated•1 year ago
|
status-firefox142:
--- → wontfix
status-firefox143:
--- → unaffected
Updated•1 year ago
|
status-firefox-esr115:
--- → wontfix
status-firefox-esr128:
--- → wontfix
status-firefox-esr140:
--- → affected
Comment 4•1 year ago
|
||
The patch landed in nightly and beta is affected.
:kershaw, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
- If no, please set
status-firefox143towontfix.
For more information, please visit BugBot documentation.
Flags: needinfo?(kershaw)
| Assignee | ||
Updated•1 year ago
|
Flags: needinfo?(kershaw)
Comment 5•1 year ago
|
||
firefox-esr140 Uplift Approval Request
- User impact if declined: Possible crash
- Code covered by automated testing: no
- Fix verified in Nightly: yes
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: N/A
- Risk associated with taking this patch: low
- Explanation of risk level: This patch is really straightforward.
- String changes made/needed: No
- Is Android affected?: yes
Attachment #9512831 -
Flags: approval-mozilla-esr140?
| Assignee | ||
Comment 6•1 year ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D264183
Updated•1 year ago
|
QA Whiteboard: [qa-triage-done-c145/b144]
Updated•1 year ago
|
Attachment #9512831 -
Flags: approval-mozilla-esr140? → approval-mozilla-esr140+
Updated•1 year ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•