1970671 - DuckDuckGo not appearing if there is no associated icon

Status: VERIFIED FIXED

(Firefox for Android :: Search, defect)

Description

[Rhodwell Malicdem [:RJ]]

Steps to reproduce

1. Turn on "Use Remote Settings Production server" in secret settings
2. Restart app
3. Go to "Default search engine" in settings

Expected behavior

DDG should be displayed

Actual behavior

DDG is not displayed

• Firefox version: Android Nightly 141.0a1

Comment 1

[Rhodwell Malicdem [:RJ]]

Attachment: Bug 1970671 - Fix DDG not appearing if there is no associated icon

Comment 2

[Mark Banner (:standard8)]

Clarifying the title slightly as staging isn't really the issue here - the issue is that if there's no icon attached to a search engine. If we did the same on production, we would have the same issue.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cdfccba82e70
https://hg.mozilla.org/integration/autoland/rev/3fdb933cb94d
Fix DDG not appearing if there is no associated icon r=android-reviewers,skhan

Comment 4

[Rhodwell Malicdem [:RJ]]

Comment on attachment 9493039 [details]
Bug 1970671 - Fix DDG not appearing if there is no associated icon

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: If a backend fetched browser engine has no associated icon attached to it, the browser engine will not appear in the list of engines in the dropdown and in settings.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Ask @standard8 to add a search engine in staging environment that does not have an icon attached

2. Enable in secret settings, "Remote Search Config..." and "Remote Settings Production server....". The first toggle should be on the second one off (to be in staging environment).
3. Then verify that search engine shows up with fallback icon.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds additional checks to ensure edge cases are covered.
• String changes made/needed: No changes
• Is Android affected?: No

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3fdb933cb94d

Comment 6

[Mira Lobontiu (Android QA)]

Attachment: 1970671.jpg

Verified as fixed on Firefox for Android Nightly 141.0a1 from 6/12 with an Oppo Find N2 Flip (Android 15).
DDG on staging server has the search icon instead of the DDG icon.

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9493039 [details]
Bug 1970671 - Fix DDG not appearing if there is no associated icon

It's too late for beta, switching uplift request from beta to release

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9493039 [details]
Bug 1970671 - Fix DDG not appearing if there is no associated icon

Approved for 140.0 RC1

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f361e7e057a8
https://hg.mozilla.org/releases/mozilla-release/rev/687d5aa108e0

Comment 10

[Mira Lobontiu (Android QA)]

Verified as fixed on Firefox for Android 140.0 build 1 with a Lenovo TB X606X (Android 10).
DDG on staging server has the search icon instead of the DDG icon.