1966119 - [SearchConfig V2] Add a fallback icon if an icon can't be obtained

Status: RESOLVED FIXED

(Firefox for Android :: Search, task)

Description

[Mark Banner (:standard8)]

In a couple of bugs related to the new search configuration, we have seen the search engines fail to display because of problems with loading the icon for an engine (e.g. bug 1965421), or not being available (bug 1966117).

If there are issues with an icon, we should have a fallback icon, so that engines can still be displayed and used by the user. For example, one case for this might be that we are rolling out a new search engine, and the client hasn't yet received the search-config-icons information (or the actual icon), and therefore would fail to display any search engine.

Hence we should have some sort of fallback. On desktop we currently use these placeholders - we could probably ask for svg or different format versions if that helps.

Comment 1

[Rhodwell Malicdem [:RJ]]

Attachment: Bug 1966119 - Fallback icon for search engines

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4e8446d1dd4f
https://hg.mozilla.org/integration/autoland/rev/9cf8c8b416d0
Fallback icon for search engines r=android-reviewers,skhan

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9cf8c8b416d0

Comment 4

[Rhodwell Malicdem [:RJ]]

Comment on attachment 9487753 [details]
Bug 1966119 - Fallback icon for search engines

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: If the search engine icon is not properly fetched or has an unsupported image type, the associated search engine will not be displayed.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Ask @standard8 to add a search engine in staging environment that does not have a relative icon

2. Enable in secret settings, "Remote Search Config..." and "Remote Settings Production server....". The first toggle should be on the second one off (to be in staging environment).
3. Then verify that search engine shows up with fallback icon.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is not risky because we are only adding checks to ensure we catch invalid search engine icons and replace them with default/fallback icons.
• String changes made/needed: No string changes
• Is Android affected?: No

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9487753 [details]
Bug 1966119 - Fallback icon for search engines

Approved for 140.0b5.

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/66e6bbe1f49b
https://hg.mozilla.org/releases/mozilla-beta/rev/8ee3100de8a0

Comment 7

[Mira Lobontiu (Android QA)]

This issue is not fixed.
Verified on the latest Firefox for Android Nightly 141.0a1 with Samsung Galaxy s24 (Android 15), and Xiaomi Mi8 Lite (Android 10).
Mark helped on staging - but the search engine did not use a "fallback icon" like it was supposed to, it was just not displayed at all - for more understanding please follow the thread on Slack.
I'll remove the qe-verify+ flag.

Comment 8

[[:skhan]]

This should be fixed by bug 1970671