1970796 - Update pdf.js or enable feature for signatures

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Clément Lefèvre]

Since some time, pdf.js release included into Firefox allows to sign documents. This is currently missing from Thunderbird.

I wanted to compare pdf.js version between Firefox and Thunderbird but was unable to find a way to get the version for both of them (I would be curious as to how are we supposed to do so?)

My best guess is that pdf.js version in Thunderbird is older than Firefox' but it could also be a feature locked behind a build flag or an about:config pref. Either cases, user would benefit from getting this feature and if not already done I think TB would benefit from being on-par with Firefox regarding pdf.js version the same way it keeps up on the Gecko versions.

Comment 1

[Magnus Melin [:mkmelin]]

Which version are you using? Please always specify version (and make sure you've tested latest). Add signature works for me on Daily.

Comment 2

[Clément Lefèvre]

Thunderbird 139.0.1. I generally don't specify version if I'm on latest stable unless it's a regression and I'm sure it appeared on this version, maybe I should. But the version field for me is to set the one the issue appeared with.

Comment 3

[Magnus Melin [:mkmelin]]

Yes, you should!

Anyway, I see there's a pdfjs.enableSignatureEditor pref. Try setting that to true.

Comment 4

[Clément Lefèvre]

(In reply to Magnus Melin [:mkmelin] from comment #3)

Yes, you should!

Anyway, I see there's a pdfjs.enableSignatureEditor pref. Try setting that to true.

This preference indeed existed and was set to true for Firefox (and its existence and value are shown as defaults [not bold]), but was nowhere to be found in Thunderbird. I had to create it and it then defaulted to true. After creation and a TB restart, the signature menu was indeed there. But the preference is still shown in bold, indicating it wasn't there by default, so the question is why the key and its value weren't created by default? (And also why is this behind a toggle defaulting to the feature being disabled…

Comment 5

[Clément Lefèvre]

To go a little bit further as it might help for this bug and the others related to pdf.js I opened: Firefox have 47 about:config prefs related to pdf.js (pdfjs.*) or 49 if you add two more with a different prefix but related. TB only had 6. Maybe some differences can come from this? I never touched any of them by hand, but a couple are still in bold nonetheless.

Both have a pdfjs.migrationVersion in bold set to 2 in case it's meaningful in any way.

Comment 6

[Toby Pilling [:tobyp]]

Attachment: Bug 1970796 - Package pdfjs default prefs and enable signature editor. r=babolivier

Comment 7

[Clément Lefèvre]

Isn't the patch duplicating a line?
Also, would it be of interest for you to see some difference between all the pdf.js-related about:config keys between Firefox and Thunderbird that I was mentioning above?

Comment 8

[Kai Engert [:KaiE:]]

As I understand it, this is an enhancement request, not a regression report.
Removing from the TB140 tracker list.

Comment 9

[Toby Pilling [:tobyp]]

Thanks @Clément Lefèvre - I fixed the line duplication. The patch will also bring in the default prefs from Firefox so with this patch they will be editable in about:config

In scanning them, there's nothing that we would want to override for Thunderbird that I can see.

Comment 10

[Toby Pilling [:tobyp]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New PDFJS feature allows users to add a visual signature to PDF attachments within Thunderbird
[Suggested wording]: Add a visual signature to PDF document attachments opened within Thunderbird.
[Links (documentation, blog post, etc)]:

Comment 11

[Kai Engert [:KaiE:]]

Because Thunderbird supports other kinds of signatures, like OpenPGP or S/MIME digital signatures, users might misinterpret a high level statement that doesn't explain what kind of signature is now supported for PDF files.

I recommend adding a clarification word to make it clear it isn't a cryptographic signature.

[Why is this notable]: New PDFJS feature allows users to add a visual signature to PDF attachments within Thunderbird
[Suggested wording]: Add a visual signature to PDF document attachments opened within Thunderbird.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5c22ed544d62
Package pdfjs default prefs and enable signature editor. r=babolivier

Comment 13

[Corey Bryant]

Thanks for the relnote feature suggestions. I went with: "Visual signatures can be added to PDF attachments opened in Thunderbird"