Closed
Bug 1970839
Opened 2 months ago
Closed 1 month ago
Update the version of Node for tests to 22.16.0 to have ESM support enabled by default
Categories
(Firefox Build System :: Toolchains, task, P3)
Firefox Build System
Toolchains
Tracking
(firefox141 fixed)
RESOLVED
FIXED
141 Branch
Tracking | Status | |
---|---|---|
firefox141 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [webdriver:m16])
Attachments
(1 file)
Over on bug 1942260 we upgraded Node to 22.11.0 which is sadly that version of Node not yet supporting ESM modules by default. The next version of Node 22.12.0 enabled it: https://github.com/nodejs/node/releases/tag/v22.12.0
Not having this support blocks our upgrade of Puppeteer to version 24.10.0. Here try build that shows the issue:
https://treeherder.mozilla.org/logviewer?job_id=511731353&repo=try&lineNumber=473
[task 2025-06-05T19:36:55.639+00:00] PID 696 | ✖ ERROR: Error [ERR_REQUIRE_ESM]: require() of ES Module /builds/worker/checkouts/gecko/remote/test/puppeteer/test/node_modules/pixelmatch/index.js from /builds/worker/checkouts/gecko/remote/test/puppeteer/test/build/golden-utils.js not supported.
[task 2025-06-05T19:36:55.639+00:00] PID 696 | Instead change the require of index.js in /builds/worker/checkouts/gecko/remote/test/puppeteer/test/build/golden-utils.js to a dynamic import() which is available in all CommonJS modules.
Assignee | ||
Comment 1•2 months ago
|
||
Actually we updated to 22.15.1 but not for the source which is required to get build. When I'm updating the versions now I'll directly bump everything to Node 22.16.0.
Assignee | ||
Comment 2•2 months ago
|
||
Updated•2 months ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Assignee | ||
Updated•2 months ago
|
Summary: Update the version of Node for tests to at least 22.12.0 to have ESM support enabled by default → Update the version of Node for tests to 22.16.0 to have ESM support enabled by default
Assignee | ||
Updated•2 months ago
|
Assignee | ||
Updated•2 months ago
|
Points: --- → 1
Priority: -- → P3
Whiteboard: [webdriver:m16]
Pushed by hskupin@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/5ec7c203c7cf
https://hg.mozilla.org/integration/autoland/rev/cf7773597fc9
Upgrade to Node 22.16.0 for tests. r=firefox-build-system-reviewers,ahochheiden
Comment 4•1 month ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox141:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•