1971121 - Spellcheck no longer highlights the misspelled word in the compose window

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P1)

Description

[Francesco (no longer active, use PM for contact)]

Attachment: spellcheck.png

Spellcheck no longer highlights the misspelled word in the compose window, see screenshot. Tested in TB 139.

Alice, can you please find the regression?

Comment 1

[Francesco (no longer active, use PM for contact)]

Attachment: spellcheck128.png

Still working in TB 128.

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to Francesco from comment #1)

...
Still working in TB 128.

If 128 is generally working for you, does that mean the following reports are also WFM in 128?

• Bug 1907532 - Spell check not working in subject after "Compose Message To" when at least one non-English dictionary is used
• Bug 1907532 - Spell check not working in subject after "Compose Message To" when at least one non-English dictionary is used

Comment 3

[Francesco (no longer active, use PM for contact)]

Bug 1907532 was confirmed for TB 128 and a few versions after that. I haven't tested it in 139.

Comment 4

[Alice0775 White]

Regression window:
https://hg-edge.mozilla.org/comm-central/pushloghtml?fromchange=63eca98887dd4e306fcb8530f900e3ce91d1059e&tochange=ff746245fd689b577999020fe58a36f804dc8025
https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=00533fc15cc769108ba3d5853d9a0fb1ad3bd20f&tochange=862a8504a89853fb5e49e2ff8e00e327846f4e7b

Suspect: Bug 1959644

Comment 5

[Francesco (no longer active, use PM for contact)]

Thank you so much, Alice!

Note that bug 1959644 is also related to bug 1966737.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

How is this dialog open? In general it is expected that the page under the modal dialog is not repainted.

Comment 7

[Francesco (no longer active, use PM for contact)]

It's opened modal:
https://searchfox.org/comm-central/rev/456c7ae9459b4c74e41b9708f9672a8ddee3b956/mail/components/compose/content/MsgComposeCommands.js#1225

There are a few cases where modal dialogs prevent the main window from being updated. When/why did this paradigm change?

In fact, sometimes the window underneath the modal dialog is repainted, see bug 1966737 comment 0.

Comment 9

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1971121 - Open spell checker as dependent, not modal dialog. r=#thunderbird-reviewers

After bug 1959644, modal dialogs are unable to refresh their opening windows.
Opening the dialog as dependent and freezing the compose window for user
interaction may be a suitable workaround.

This re-enables immediate highlighting or replacing of misspelled words in the
editor.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/781541bb7f85
Open spell checker as dependent, not modal dialog. r=tobyp

Comment 11

[Calum Mackay]

possible regression? see bug 1974125

Comment 12

[Wayne Mery (:wsmwk)]

Please nominate for beta 141 uplift

Comment 13

[Francesco (no longer active, use PM for contact)]

(In reply to Wayne Mery (:wsmwk) from comment #12)

Please nominate for beta 141 uplift

Please note the regression this caused, bug 1974125. Quite a bad one since people may rely on "spell check before send" and the message just gets send.

Comment 14

[Hartmut Welpmann [:welpy-cw]]

(In reply to Wayne Mery (:wsmwk) from comment #12)

Please nominate for beta 141 uplift

We should wait for the regression fix.

Comment 15

[Wayne Mery (:wsmwk)]

(In reply to Hartmut Welpmann [:welpy-cw] from comment #14)

(In reply to Wayne Mery (:wsmwk) from comment #12)

Please nominate for beta 141 uplift

We should wait for the regression fix.

Ideally both are needed of course.

Bt we don't want this bug on esr140 and it ships on Monday so time is very short. If we can only get one into esr140 then I think we should do so.

ALso, because of the release funk/fun of the past week, we have not yet build release 140. BETA 141 is hopefully happening today. RELEASE 140 comes next - exact timing uncertain but I don't see us shipping on Friday or before, so there is actually opportunity to take this on release 140.

Corey will try to coordinate.

Comment 16

[Corey Bryant]

Hartmut or others, can you add a beta and 140esr uplift request for this?

Comment 17

[Corey Bryant]

Comment on attachment 9495789 [details]
Bug 1971121 - Open spell checker as dependent, not modal dialog. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 18

[Corey Bryant]

Comment on attachment 9495789 [details]
Bug 1971121 - Open spell checker as dependent, not modal dialog. r=#thunderbird-reviewers

[Triage Comment]
Already on beta

Comment 19

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9495789 [details]
Bug 1971121 - Open spell checker as dependent, not modal dialog. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Regression by upstream changes.
• User impact if declined: No visual feedback in message text from spell check.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1974125
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not uplifting this seems worse, soon to be verified in Beta.
• String changes made/needed: None.

Comment 20

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed using Windows 11, Windows 10, Ubuntu 25 and macOS 15.5 with the Treeherder builds from here.

Spellcheck now highlights the misspelled word in the compose window.

Comment 21

[Corey Bryant]

Comment on attachment 9495789 [details]
Bug 1971121 - Open spell checker as dependent, not modal dialog. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr140

Comment 22

[Corey Bryant]

Comment on attachment 9495789 [details]
Bug 1971121 - Open spell checker as dependent, not modal dialog. r=#thunderbird-reviewers

[Triage Comment]
Approved for release

Comment 23

[Corey Bryant]

Thunderbird 140.0:
https://hg.mozilla.org/releases/comm-release/rev/a7c468b25d54

Comment 24

[Corey Bryant]

Thunderbird 140.0esr:
https://hg-edge.mozilla.org/releases/comm-esr140/rev/7a0b90376f0efc3164fd0a797d3c8ee5fac8e577