1971161 - Get monitor HDR info async and refresh HDR state after system change

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Recent implementation of mozilla::widget::IsMonitorHDR() is not re-entrant and causes crashes. We need to rework it in order to get correct monitor info. Follow up fom Bug 1968308.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1971161 [Wayland] Move system monitor probe to ScreenGetterGtk class r?emilio

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1971161 [Wayland] Get HDR monitor info async r?emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/adc14d3cd7e5
https://hg.mozilla.org/integration/autoland/rev/f040e61b0b3b
[Wayland] Move system monitor probe to ScreenGetterGtk class r=emilio
https://github.com/mozilla-firefox/firefox/commit/49407f49202c
https://hg.mozilla.org/integration/autoland/rev/1b7c85023641
[Wayland] Get HDR monitor info async r=emilio

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f040e61b0b3b
https://hg.mozilla.org/mozilla-central/rev/1b7c85023641

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8273231c00c5
https://hg.mozilla.org/mozilla-central/rev/dc912741adc2
Revert "Bug 1971161 [Wayland] Get HDR monitor info async r=emilio" for causing Bug 1971697 This reverts commit 49407f49202c1488708a554d528feccf4a3f85a0.

Comment 7

[agoloman]

Backed out as requested by Mossop.

• Backout link.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1971161 [Wayland] Refresh monitor setup on wp_color_management_output_v1::image_description_changed signal r?emilio

Comment 10

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=99bab7dbb361b020181b685236a10509918d9607

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1971161 [Wayland] Move system monitor probe to ScreenGetterGtk class r?emilio

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1971161 [Wayland] Get HDR monitor info async r?emilio

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1971161 [Wayland] Refresh monitor setup on wp_color_management_output_v1::image_description_changed signal r?emilio

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/67224d369885
https://hg.mozilla.org/integration/autoland/rev/13eb4d64e83f
[Wayland] Move system monitor probe to ScreenGetterGtk class r=emilio
https://github.com/mozilla-firefox/firefox/commit/376068ce7ff2
https://hg.mozilla.org/integration/autoland/rev/e977efc8bc30
[Wayland] Get HDR monitor info async r=emilio
https://github.com/mozilla-firefox/firefox/commit/74862fd50ce2
https://hg.mozilla.org/integration/autoland/rev/f562693b5b30
[Wayland] Refresh monitor setup on wp_color_management_output_v1::image_description_changed signal r=emilio

Comment 15

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/13eb4d64e83f
https://hg.mozilla.org/mozilla-central/rev/e977efc8bc30
https://hg.mozilla.org/mozilla-central/rev/f562693b5b30